mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 17:46:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Bumping test coverage to 100%

Browse Source
This commit is contained in:
Lino Layani 2025-05-21 17:51:48 -04:00
parent cc0d72363c
commit 84822840b4
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
pkg/tlsutils/tlsconfig_test.go
View File

@ -107,6 +107,48 @@ func TestCreateTLSConfig(t *testing.T) {
assert.Equal(t, actual.MinVersion, uint16(defaultMinVersion))
},
},
{
"Invalid CA file returns error",
"prefix",
"invalid-ca-content",
"",
"",
"",
"",
func(actual *tls.Config, err error) {
assert.Error(t, err)
assert.Contains(t, err.Error(), "could not read root certs")
},
},
{
"Invalid CA file path returns error",
"prefix",
"ca-path-does-not-exist",
"",
"",
"",
"server-name",
func(actual *tls.Config, err error) {
assert.Error(t, err)
assert.Contains(t, err.Error(), "error reading /path/does/not/exist")
},
},
{
"Complete config with CA, cert, and key returns valid tls.Config",
"prefix",
rsaCertPEM,
rsaCertPEM,
rsaKeyPEM,
"",
"server-name",
func(actual *tls.Config, err error) {
require.NoError(t, err)
assert.Equal(t, "server-name", actual.ServerName)
assert.NotNil(t, actual.Certificates[0])
assert.NotNil(t, actual.RootCAs)
assert.False(t, actual.InsecureSkipVerify)
},
},
}
for _, tc := range tests {
@ -120,6 +162,10 @@ func TestCreateTLSConfig(t *testing.T) {
t.Setenv(fmt.Sprintf("%s_CA_FILE", tc.prefix), path)
}
if tc.caFile == "ca-path-does-not-exist" {
t.Setenv(fmt.Sprintf("%s_CA_FILE", tc.prefix), "/path/does/not/exist")
}
if tc.certFile != "" {
path := fmt.Sprintf("%s/certFile", dir)
utils.WriteToFile(path, tc.certFile)