mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-10-29 17:51:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only update PiHole entries when they have actually changed

Browse Source
This commit is contained in:
Scott Fleener 2023-01-07 19:30:07 -05:00
parent 7b7b84dce2
commit 83d880421c
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
provider/pihole/pihole.go
View File

@ -74,25 +74,40 @@ func (p *PiholeProvider) Records(ctx context.Context) ([]*endpoint.Endpoint, err
// ApplyChanges implements Provider, syncing desired state with the Pi-hole server Local DNS.
func (p *PiholeProvider) ApplyChanges(ctx context.Context, changes *plan.Changes) error {
// Handle deletions first - there are no endpoints for updating in place.
// Handle pure deletes first.
for _, ep := range changes.Delete {
if err := p.api.deleteRecord(ctx, ep); err != nil {
return err
}
}
// Handle updated state - there are no endpoints for updating in place.
updateNew := make(map[string]*endpoint.Endpoint)
for _, ep := range changes.UpdateNew {
updateNew[ep.DNSName] = ep
}
for _, ep := range changes.UpdateOld {
// Check if this existing entry has an exact match for an updated entry, and skip it if so.
if newRecord := updateNew[ep.DNSName]; newRecord != nil {
// PiHole only has a single target and a record type, no need to compare other fields.
if newRecord.Targets.String() == ep.Targets.String() && newRecord.RecordType == ep.RecordType {
delete(updateNew, ep.DNSName)
continue
}
}
if err := p.api.deleteRecord(ctx, ep); err != nil {
return err
}
}
// Handle desired state
// Handle pure creates before applying new updated state.
for _, ep := range changes.Create {
if err := p.api.createRecord(ctx, ep); err != nil {
return err
}
}
for _, ep := range changes.UpdateNew {
for _, ep := range updateNew {
if err := p.api.createRecord(ctx, ep); err != nil {
return err
}