From 83d58fae03f514a789230101e95e1096871d5d32 Mon Sep 17 00:00:00 2001 From: Jonas-Taha El Sesiy Date: Tue, 16 May 2023 08:46:54 -0700 Subject: [PATCH] Remove UpdateOld changeset for Azure The underlying SDK uses `recordSetsClient.CreateOrUpdate()` [doc](https://docs.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update) which allows us to exclusively rely on UpdateNew for record set updates. As a result, we're no longer running the risk of zone update failures causing outages as outlined in #2918 Fix https://github.com/kubernetes-sigs/external-dns/issues/2918 --- provider/azure/azure.go | 4 ---- provider/azure/azure_private_dns.go | 4 ---- provider/azure/azure_privatedns_test.go | 3 --- provider/azure/azure_test.go | 5 ----- 4 files changed, 16 deletions(-) diff --git a/provider/azure/azure.go b/provider/azure/azure.go index b56a21320..bca9c841d 100644 --- a/provider/azure/azure.go +++ b/provider/azure/azure.go @@ -250,10 +250,6 @@ func (p *AzureProvider) mapChanges(zones []dns.Zone, changes *plan.Changes) (azu mapChange(deleted, change) } - for _, change := range changes.UpdateOld { - mapChange(deleted, change) - } - for _, change := range changes.Create { mapChange(updated, change) } diff --git a/provider/azure/azure_private_dns.go b/provider/azure/azure_private_dns.go index e3ab40c48..ee2e478bd 100644 --- a/provider/azure/azure_private_dns.go +++ b/provider/azure/azure_private_dns.go @@ -237,10 +237,6 @@ func (p *AzurePrivateDNSProvider) mapChanges(zones []privatedns.PrivateZone, cha mapChange(deleted, change) } - for _, change := range changes.UpdateOld { - mapChange(deleted, change) - } - for _, change := range changes.Create { mapChange(updated, change) } diff --git a/provider/azure/azure_privatedns_test.go b/provider/azure/azure_privatedns_test.go index e728659c4..061b0f4d6 100644 --- a/provider/azure/azure_privatedns_test.go +++ b/provider/azure/azure_privatedns_test.go @@ -342,11 +342,8 @@ func TestAzurePrivateDNSApplyChanges(t *testing.T) { testAzurePrivateDNSApplyChangesInternal(t, false, &recordsClient) validateAzureEndpoints(t, recordsClient.deletedEndpoints, []*endpoint.Endpoint{ - endpoint.NewEndpoint("old.example.com", endpoint.RecordTypeA, ""), - endpoint.NewEndpoint("oldcname.example.com", endpoint.RecordTypeCNAME, ""), endpoint.NewEndpoint("deleted.example.com", endpoint.RecordTypeA, ""), endpoint.NewEndpoint("deletedcname.example.com", endpoint.RecordTypeCNAME, ""), - endpoint.NewEndpoint("oldmail.example.com", endpoint.RecordTypeMX, ""), }) validateAzureEndpoints(t, recordsClient.updatedEndpoints, []*endpoint.Endpoint{ diff --git a/provider/azure/azure_test.go b/provider/azure/azure_test.go index 050ab3d92..ba831586c 100644 --- a/provider/azure/azure_test.go +++ b/provider/azure/azure_test.go @@ -349,11 +349,8 @@ func TestAzureApplyChanges(t *testing.T) { testAzureApplyChangesInternal(t, false, &recordsClient) validateAzureEndpoints(t, recordsClient.deletedEndpoints, []*endpoint.Endpoint{ - endpoint.NewEndpoint("old.example.com", endpoint.RecordTypeA, ""), - endpoint.NewEndpoint("oldcname.example.com", endpoint.RecordTypeCNAME, ""), endpoint.NewEndpoint("deleted.example.com", endpoint.RecordTypeA, ""), endpoint.NewEndpoint("deletedcname.example.com", endpoint.RecordTypeCNAME, ""), - endpoint.NewEndpoint("oldmail.example.com", endpoint.RecordTypeMX, ""), }) validateAzureEndpoints(t, recordsClient.updatedEndpoints, []*endpoint.Endpoint{ @@ -508,8 +505,6 @@ func TestAzureApplyChangesZoneName(t *testing.T) { testAzureApplyChangesInternalZoneName(t, false, &recordsClient) validateAzureEndpoints(t, recordsClient.deletedEndpoints, []*endpoint.Endpoint{ - endpoint.NewEndpoint("old.foo.example.com", endpoint.RecordTypeA, ""), - endpoint.NewEndpoint("oldcname.foo.example.com", endpoint.RecordTypeCNAME, ""), endpoint.NewEndpoint("deleted.foo.example.com", endpoint.RecordTypeA, ""), endpoint.NewEndpoint("deletedcname.foo.example.com", endpoint.RecordTypeCNAME, ""), })