mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-07 01:56:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: reuse existing extractLoadBalancerTargets function

Browse Source
This commit is contained in:
Frederic Mereu 2023-08-12 13:49:17 +02:00
parent f9099b8bfc
commit 73862a802b
No known key found for this signature in database
GPG Key ID: 8CE4FC10C7F26E85
1 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
source/ambassador_host.go
View File

@ -184,11 +184,6 @@ func (sc *ambassadorHostSource) endpointsFromHost(ctx context.Context, host *amb
} }
func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Context, service string) (endpoint.Targets, error) { func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Context, service string) (endpoint.Targets, error) {
var (
targets endpoint.Targets
externalIPs endpoint.Targets
)
lbNamespace, lbName, err := parseAmbLoadBalancerService(service) lbNamespace, lbName, err := parseAmbLoadBalancerService(service)
if err != nil { if err != nil {
return nil, err return nil, err
@ -199,24 +194,7 @@ func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Co
return nil, err return nil, err
} }
for _, lb := range svc.Status.LoadBalancer.Ingress { var targets = extractLoadBalancerTargets(svc, true)
if lb.IP != "" {
targets = append(targets, lb.IP)
}
if lb.Hostname != "" {
targets = append(targets, lb.Hostname)
}
}
if svc.Spec.ExternalIPs != nil {
for _, ext := range svc.Spec.ExternalIPs {
externalIPs = append(externalIPs, ext)
}
}
if len(externalIPs) > 0 {
return externalIPs, nil
}
return targets, nil return targets, nil
} }