mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2026-05-05 06:36:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

ingress source: check for duplicate classname configs

Browse Source 
we don't want to get incompatible restrictions by letting someone set
"--ingress-class" and --annotation-filter="kubernetes.io/ingress.class"
at the same time
This commit is contained in:
Dave Salisbury 2021-10-02 16:02:33 +10:00
parent ac0c4be36a
commit 71a672fe72
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/ingress.go
View File

@ -18,6 +18,7 @@ package source
import (
"context"
"errors"
"fmt"
"sort"
"strings"
@ -70,6 +71,21 @@ func NewIngressSource(kubeClient kubernetes.Interface, namespace, annotationFilt
return nil, err
}
// ensure that ingress class is only set in either the ingressClassNames or
// annotationFilter but not both
if ingressClassNames != nil && annotationFilter != "" {
selector, err := getLabelSelector(annotationFilter)
if err != nil {
return nil, err
}
requirements, _ := selector.Requirements()
for _, requirement := range requirements {
if requirement.Key() == "kubernetes.io/ingress.class" {
return nil, errors.New("--ingress-class is mutually exclusive with kubernetes.io/ingress.class annotation")
}
}
}
// Use shared informer to listen for add/update/delete of ingresses in the specified namespace.
// Set resync period to 0, to prevent processing when nothing has changed.
informerFactory := kubeinformers.NewSharedInformerFactoryWithOptions(kubeClient, 0, kubeinformers.WithNamespace(namespace))