diff --git a/docs/tutorials/akamai-fastdns.md b/docs/tutorials/akamai-fastdns.md index 30d67287e..6dfae56c2 100644 --- a/docs/tutorials/akamai-fastdns.md +++ b/docs/tutorials/akamai-fastdns.md @@ -95,10 +95,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] @@ -192,4 +189,4 @@ spec: **Important!**: Don't run dig, nslookup or similar immediately. You'll get hit by [negative DNS caching](https://tools.ietf.org/html/rfc2308), which is hard to flush. -Wait about 30s-1m (interval for external-dns to kick in) \ No newline at end of file +Wait about 30s-1m (interval for external-dns to kick in) diff --git a/docs/tutorials/alibabacloud.md b/docs/tutorials/alibabacloud.md index a470bd797..73d601084 100644 --- a/docs/tutorials/alibabacloud.md +++ b/docs/tutorials/alibabacloud.md @@ -147,10 +147,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/aws-sd.md b/docs/tutorials/aws-sd.md index c013bae61..b0fa610bf 100644 --- a/docs/tutorials/aws-sd.md +++ b/docs/tutorials/aws-sd.md @@ -108,10 +108,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/aws.md b/docs/tutorials/aws.md index dedac4192..d3b814fb2 100644 --- a/docs/tutorials/aws.md +++ b/docs/tutorials/aws.md @@ -172,10 +172,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/azure-private-dns.md b/docs/tutorials/azure-private-dns.md index 81ff2b2c0..a362457e1 100644 --- a/docs/tutorials/azure-private-dns.md +++ b/docs/tutorials/azure-private-dns.md @@ -194,10 +194,7 @@ metadata: name: externaldns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] @@ -268,10 +265,7 @@ metadata: name: externaldns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] @@ -399,4 +393,4 @@ $ az network private-dns record-set a list -g externaldns -z example.com Substitute the zone for the one created above if a different domain was used. -This should show the external IP address of the service as the A record for your domain ('@' indicates the record is for the zone itself). \ No newline at end of file +This should show the external IP address of the service as the A record for your domain ('@' indicates the record is for the zone itself). diff --git a/docs/tutorials/azure.md b/docs/tutorials/azure.md index 02a5e4398..0a62de70a 100644 --- a/docs/tutorials/azure.md +++ b/docs/tutorials/azure.md @@ -221,10 +221,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] @@ -298,10 +295,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/cloudflare.md b/docs/tutorials/cloudflare.md index def528fc8..3f2faf644 100644 --- a/docs/tutorials/cloudflare.md +++ b/docs/tutorials/cloudflare.md @@ -75,10 +75,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/contour.md b/docs/tutorials/contour.md index 202f3bbed..aa9448f3a 100644 --- a/docs/tutorials/contour.md +++ b/docs/tutorials/contour.md @@ -48,10 +48,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/coredns.md b/docs/tutorials/coredns.md index a7dd1e14c..1d3f64090 100644 --- a/docs/tutorials/coredns.md +++ b/docs/tutorials/coredns.md @@ -128,10 +128,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/designate.md b/docs/tutorials/designate.md index 40f5418f1..875eb14d9 100644 --- a/docs/tutorials/designate.md +++ b/docs/tutorials/designate.md @@ -93,7 +93,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: [""] resources: ["pods"] diff --git a/docs/tutorials/digitalocean.md b/docs/tutorials/digitalocean.md index d68a0bfa5..c23fe9878 100644 --- a/docs/tutorials/digitalocean.md +++ b/docs/tutorials/digitalocean.md @@ -69,10 +69,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/dnsimple.md b/docs/tutorials/dnsimple.md index 98350c634..586efe940 100644 --- a/docs/tutorials/dnsimple.md +++ b/docs/tutorials/dnsimple.md @@ -60,10 +60,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/exoscale.md b/docs/tutorials/exoscale.md index 8674b1ac8..64f6efbe2 100644 --- a/docs/tutorials/exoscale.md +++ b/docs/tutorials/exoscale.md @@ -72,10 +72,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/gke.md b/docs/tutorials/gke.md index de9a21602..d402ba7d5 100644 --- a/docs/tutorials/gke.md +++ b/docs/tutorials/gke.md @@ -116,10 +116,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/hostport.md b/docs/tutorials/hostport.md index 0441aec39..7568b36b4 100644 --- a/docs/tutorials/hostport.md +++ b/docs/tutorials/hostport.md @@ -56,10 +56,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/infoblox.md b/docs/tutorials/infoblox.md index 9e13bc1e0..edf7b9519 100644 --- a/docs/tutorials/infoblox.md +++ b/docs/tutorials/infoblox.md @@ -109,10 +109,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/istio.md b/docs/tutorials/istio.md index 74556c808..d397709af 100644 --- a/docs/tutorials/istio.md +++ b/docs/tutorials/istio.md @@ -54,10 +54,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/linode.md b/docs/tutorials/linode.md index cc594d200..859b87aa5 100644 --- a/docs/tutorials/linode.md +++ b/docs/tutorials/linode.md @@ -65,10 +65,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/nginx-ingress.md b/docs/tutorials/nginx-ingress.md index 6a642bb2e..fd19ff324 100644 --- a/docs/tutorials/nginx-ingress.md +++ b/docs/tutorials/nginx-ingress.md @@ -222,10 +222,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/ns1.md b/docs/tutorials/ns1.md index 7a0ce4713..014deacef 100644 --- a/docs/tutorials/ns1.md +++ b/docs/tutorials/ns1.md @@ -85,10 +85,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/oracle.md b/docs/tutorials/oracle.md index 246a8418e..98918816c 100644 --- a/docs/tutorials/oracle.md +++ b/docs/tutorials/oracle.md @@ -51,10 +51,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/pdns.md b/docs/tutorials/pdns.md index de1e2c371..5a555faa4 100644 --- a/docs/tutorials/pdns.md +++ b/docs/tutorials/pdns.md @@ -76,7 +76,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/rcodezero.md b/docs/tutorials/rcodezero.md index ad79c211c..4338523ba 100644 --- a/docs/tutorials/rcodezero.md +++ b/docs/tutorials/rcodezero.md @@ -80,10 +80,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/rdns.md b/docs/tutorials/rdns.md index fda112a8e..aa7635421 100644 --- a/docs/tutorials/rdns.md +++ b/docs/tutorials/rdns.md @@ -76,10 +76,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/rfc2136.md b/docs/tutorials/rfc2136.md index d848a77a1..4c77f34fe 100644 --- a/docs/tutorials/rfc2136.md +++ b/docs/tutorials/rfc2136.md @@ -144,6 +144,8 @@ rules: - "" resources: - services + - endpoints + - pods verbs: - get - watch diff --git a/docs/tutorials/transip.md b/docs/tutorials/transip.md index ddcbbd537..a416b1bc3 100644 --- a/docs/tutorials/transip.md +++ b/docs/tutorials/transip.md @@ -67,10 +67,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/docs/tutorials/vinyldns.md b/docs/tutorials/vinyldns.md index 2fbe025af..6c5b6fc5a 100644 --- a/docs/tutorials/vinyldns.md +++ b/docs/tutorials/vinyldns.md @@ -97,10 +97,7 @@ metadata: name: external-dns rules: - apiGroups: [""] - resources: ["services","endpoints"] - verbs: ["get","watch","list"] -- apiGroups: [""] - resources: ["pods"] + resources: ["services","endpoints","pods"] verbs: ["get","watch","list"] - apiGroups: ["extensions"] resources: ["ingresses"] diff --git a/source/service.go b/source/service.go index db6c2c72f..e32961aef 100644 --- a/source/service.go +++ b/source/service.go @@ -101,7 +101,6 @@ func NewServiceSource(kubeClient kubernetes.Interface, namespace, annotationFilt endpointsInformer.Informer().AddEventHandler( cache.ResourceEventHandlerFuncs{ AddFunc: func(obj interface{}) { - log.Debug("endpoints added") }, }, ) diff --git a/source/service_test.go b/source/service_test.go index 3325bf3ae..ee96335b2 100644 --- a/source/service_test.go +++ b/source/service_test.go @@ -1852,8 +1852,7 @@ func TestHeadlessServices(t *testing.T) { _, err := kubernetes.CoreV1().Services(service.Namespace).Create(service) require.NoError(t, err) - var addresses []v1.EndpointAddress - var notReadyAddresses []v1.EndpointAddress + var addresses, notReadyAddresses []v1.EndpointAddress for i, podname := range tc.podnames { pod := &v1.Pod{ Spec: v1.PodSpec{