diff --git a/source/dedupsource.go b/source/dedupsource.go index 0ae79e988..3ac90d5db 100644 --- a/source/dedupsource.go +++ b/source/dedupsource.go @@ -18,6 +18,7 @@ package source import ( "context" + "strings" log "github.com/sirupsen/logrus" @@ -45,7 +46,11 @@ func (ms *dedupSource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, err } for _, ep := range endpoints { - identifier := ep.RecordType + " / " + ep.DNSName + " / " + ep.SetIdentifier + " / " + ep.Targets.String() + if ep == nil { + continue + } + + identifier := strings.Join([]string{ep.RecordType, ep.DNSName, ep.SetIdentifier, ep.Targets.String()}, "/") if _, ok := collected[identifier]; ok { log.Debugf("Removing duplicate endpoint %s", ep) diff --git a/source/dedupsource_test.go b/source/dedupsource_test.go index c371db28a..d387f8819 100644 --- a/source/dedupsource_test.go +++ b/source/dedupsource_test.go @@ -111,6 +111,17 @@ func testDedupEndpoints(t *testing.T) { {DNSName: "foo.example.org", RecordType: "AAAA", Targets: endpoint.Targets{"1.2.3.4"}}, }, }, + { + "two endpoints with same dnsname, one with record type, one without, and same target return two endpoints", + []*endpoint.Endpoint{ + {DNSName: "foo.example.org", RecordType: "A", Targets: endpoint.Targets{"1.2.3.4"}}, + {DNSName: "foo.example.org", Targets: endpoint.Targets{"1.2.3.4"}}, + }, + []*endpoint.Endpoint{ + {DNSName: "foo.example.org", RecordType: "A", Targets: endpoint.Targets{"1.2.3.4"}}, + {DNSName: "foo.example.org", Targets: endpoint.Targets{"1.2.3.4"}}, + }, + }, } { t.Run(tc.title, func(t *testing.T) { mockSource := new(testutils.MockSource)