mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-07 01:56:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: don't iterate over load balancer if not using result

Browse Source
This commit is contained in:
John Gardiner Myers 2023-06-25 12:25:29 -07:00
parent ae0c06e3e6
commit 4ee8bae85c
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source/service.go
View File

@ -562,12 +562,12 @@ func extractServiceExternalName(svc *v1.Service) endpoint.Targets {
} }
func extractLoadBalancerTargets(svc *v1.Service, resolveLoadBalancerHostname bool) endpoint.Targets { func extractLoadBalancerTargets(svc *v1.Service, resolveLoadBalancerHostname bool) endpoint.Targets {
var ( if len(svc.Spec.ExternalIPs) > 0 {
targets endpoint.Targets return svc.Spec.ExternalIPs
externalIPs endpoint.Targets }
)
// Create a corresponding endpoint for each configured external entrypoint. // Create a corresponding endpoint for each configured external entrypoint.
var targets endpoint.Targets
for _, lb := range svc.Status.LoadBalancer.Ingress { for _, lb := range svc.Status.LoadBalancer.Ingress {
if lb.IP != "" { if lb.IP != "" {
targets = append(targets, lb.IP) targets = append(targets, lb.IP)
@ -588,16 +588,6 @@ func extractLoadBalancerTargets(svc *v1.Service, resolveLoadBalancerHostname boo
} }
} }
if svc.Spec.ExternalIPs != nil {
for _, ext := range svc.Spec.ExternalIPs {
externalIPs = append(externalIPs, ext)
}
}
if len(externalIPs) > 0 {
return externalIPs
}
return targets return targets
} }