diff --git a/provider/tencentcloud/cloudapi/mockapi.go b/provider/tencentcloud/cloudapi/mockapi.go index 3484ddc12..df5e64b46 100644 --- a/provider/tencentcloud/cloudapi/mockapi.go +++ b/provider/tencentcloud/cloudapi/mockapi.go @@ -71,7 +71,7 @@ func (api *mockAPIService) DeletePrivateZoneRecord(request *privatedns.DeletePri } for _, privateZoneRecord := range api.privateZoneRecords[*request.ZoneId] { deleteflag := false - if request.RecordIdSet != nil && len(request.RecordIdSet) != 0 { + if len(request.RecordIdSet) != 0 { for _, recordId := range request.RecordIdSet { if *privateZoneRecord.RecordId == *recordId { deleteflag = true diff --git a/provider/tencentcloud/cloudapi/tencentapi.go b/provider/tencentcloud/cloudapi/tencentapi.go index 5997cb67f..1c8338e07 100644 --- a/provider/tencentcloud/cloudapi/tencentapi.go +++ b/provider/tencentcloud/cloudapi/tencentapi.go @@ -258,16 +258,16 @@ func dealWithError(action Action, request string, err error) bool { } func APIErrorRecord(apiAction Action, request string, response string, err error) { - log.Infof(fmt.Sprintf("APIError API: %s/%s Request: %s, Response: %s, Error: %s", apiAction.Service, apiAction.Name, request, response, err.Error())) + log.Infof("APIError API: %s/%s Request: %s, Response: %s, Error: %s", apiAction.Service, apiAction.Name, request, response, err.Error()) } func APIRecord(apiAction Action, request string, response string) { message := fmt.Sprintf("APIRecord API: %s/%s Request: %s, Response: %s", apiAction.Service, apiAction.Name, request, response) if apiAction.ReadOnly { - // log.Infof(message) + // log.Info(message) } else { - log.Infof(message) + log.Info(message) } } diff --git a/provider/tencentcloud/dnspod.go b/provider/tencentcloud/dnspod.go index f2e714cf8..30fb81ac0 100644 --- a/provider/tencentcloud/dnspod.go +++ b/provider/tencentcloud/dnspod.go @@ -89,7 +89,7 @@ func (p *TencentCloudProvider) getDomainList() ([]*dnspod.DomainListItem, error) if err != nil { return nil, err } - if response.Response.DomainList != nil && len(response.Response.DomainList) > 0 { + if len(response.Response.DomainList) > 0 { if !p.domainFilter.IsConfigured() { domainList = append(domainList, response.Response.DomainList...) } else { @@ -119,7 +119,7 @@ func (p *TencentCloudProvider) getDomainRecordList(domain string) ([]*dnspod.Rec if err != nil { return nil, err } - if response.Response.RecordList != nil && len(response.Response.RecordList) > 0 { + if len(response.Response.RecordList) > 0 { for _, record := range response.Response.RecordList { if *record.Name == "@" && *record.Type == "NS" { // Special Record, Skip it. continue diff --git a/provider/tencentcloud/privatedns.go b/provider/tencentcloud/privatedns.go index 7bfc9d326..e209f535f 100644 --- a/provider/tencentcloud/privatedns.go +++ b/provider/tencentcloud/privatedns.go @@ -110,7 +110,7 @@ func (p *TencentCloudProvider) getPrivateZones() ([]*privatedns.PrivateZone, err if err != nil { return nil, err } - if response.Response.PrivateZoneSet != nil && len(response.Response.PrivateZoneSet) > 0 { + if len(response.Response.PrivateZoneSet) > 0 { privateZones = append(privateZones, response.Response.PrivateZoneSet...) } totalCount = *response.Response.TotalCount @@ -140,7 +140,7 @@ func (p *TencentCloudProvider) getPrivateZoneRecords(zoneId string) ([]*privated if err != nil { return nil, err } - if response.Response.RecordSet != nil && len(response.Response.RecordSet) > 0 { + if len(response.Response.RecordSet) > 0 { privateZoneRecords = append(privateZoneRecords, response.Response.RecordSet...) } totalCount = *response.Response.TotalCount diff --git a/provider/vinyldns/vinyldns.go b/provider/vinyldns/vinyldns.go index 7dc98c2d7..fefc56e6e 100644 --- a/provider/vinyldns/vinyldns.go +++ b/provider/vinyldns/vinyldns.go @@ -92,7 +92,7 @@ func (p *vinyldnsProvider) Records(ctx context.Context) (endpoints []*endpoint.E continue } - log.Infof(fmt.Sprintf("Zone: [%s:%s]", zone.ID, zone.Name)) + log.Infof("Zone: [%s:%s]", zone.ID, zone.Name) records, err := p.client.RecordSets(zone.ID) if err != nil { return nil, err @@ -101,7 +101,7 @@ func (p *vinyldnsProvider) Records(ctx context.Context) (endpoints []*endpoint.E for _, r := range records { if provider.SupportedRecordType(r.Type) { recordsCount := len(r.Records) - log.Debugf(fmt.Sprintf("%s.%s.%d.%s", r.Name, r.Type, recordsCount, zone.Name)) + log.Debugf("%s.%s.%d.%s", r.Name, r.Type, recordsCount, zone.Name) // TODO: AAAA Records if len(r.Records) > 0 {