mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-05 17:16:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

following review

Browse Source
This commit is contained in:
Michel Loiseleur 2023-12-07 10:42:36 +01:00
parent d98a28ee43
commit 3c570496e9
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
provider/ns1/ns1.go
View File

@ -179,7 +179,7 @@ func (p *NS1Provider) Records(ctx context.Context) ([]*endpoint.Endpoint, error)
// ns1BuildRecord returns a dns.Record for a change set
func (p *NS1Provider) ns1BuildRecord(zoneName string, change *ns1Change) *dns.Record {
record := dns.NewRecord(zoneName, change.Endpoint.DNSName, change.Endpoint.RecordType, nil, nil)
record := dns.NewRecord(zoneName, change.Endpoint.DNSName, change.Endpoint.RecordType, map[string]string{}, []string{})
for _, v := range change.Endpoint.Targets {
record.AddAnswer(dns.NewAnswer(strings.Split(v, " ")))
}

10
provider/rfc2136/rfc2136_test.go
View File

@ -48,7 +48,7 @@ func newStub() *rfc2136Stub {
func (r *rfc2136Stub) SendMessage(msg *dns.Msg) error {
log.Info(msg.String())
lines := extractAuthoritySectionFromMessage(msg)
lines := extractUpdateSectionFromMessage(msg)
for _, line := range lines {
// break at first empty line
if len(strings.TrimSpace(line)) == 0 {
@ -98,10 +98,10 @@ func createRfc2136StubProvider(stub *rfc2136Stub) (provider.Provider, error) {
return NewRfc2136Provider("", 0, nil, false, "key", "secret", "hmac-sha512", true, endpoint.DomainFilter{}, false, 300*time.Second, false, "", "", "", 50, stub)
}
func extractAuthoritySectionFromMessage(msg fmt.Stringer) []string {
func extractUpdateSectionFromMessage(msg fmt.Stringer) []string {
const searchPattern = "UPDATE SECTION:"
authoritySectionOffset := strings.Index(msg.String(), searchPattern)
return strings.Split(strings.TrimSpace(msg.String()[authoritySectionOffset+len(searchPattern):]), "\n")
updateSectionOffset := strings.Index(msg.String(), searchPattern)
return strings.Split(strings.TrimSpace(msg.String()[updateSectionOffset+len(searchPattern):]), "\n")
}
// TestRfc2136GetRecordsMultipleTargets simulates a single record with multiple targets.
@ -241,7 +241,7 @@ func TestRfc2136ApplyChangesWithDifferentTTLs(t *testing.T) {
err = provider.ApplyChanges(context.Background(), p)
assert.NoError(t, err)
createRecords := extractAuthoritySectionFromMessage(stub.createMsgs[0])
createRecords := extractUpdateSectionFromMessage(stub.createMsgs[0])
assert.Equal(t, 3, len(createRecords))
assert.True(t, strings.Contains(createRecords[0], "v1.foo.com"))
assert.True(t, strings.Contains(createRecords[0], "2.1.1.1"))