From 2f0149097d76d44af56e56a79cc9041f03bc877e Mon Sep 17 00:00:00 2001 From: Jaideep Bellani Date: Mon, 19 Jul 2021 16:13:22 -0500 Subject: [PATCH] bluecat: do not return if owner not found We were returning an error when the owner string was not found and this was causing the loop to quit. This is not ideal because it does not fetch the other records once it returns. --- provider/bluecat/bluecat.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/provider/bluecat/bluecat.go b/provider/bluecat/bluecat.go index c8410cf20..dc3b12edb 100644 --- a/provider/bluecat/bluecat.go +++ b/provider/bluecat/bluecat.go @@ -215,7 +215,7 @@ func (p *BluecatProvider) Records(ctx context.Context) (endpoints []*endpoint.En tempEndpoint := endpoint.NewEndpoint(rec.Name, endpoint.RecordTypeTXT, rec.Properties) tempEndpoint.Labels[endpoint.OwnerLabelKey], err = extractOwnerfromTXTRecord(rec.Properties) if err != nil { - return nil, errors.Wrapf(err, "Error fetching owner from record") + log.Debugf("External DNS Owner %s", err) } endpoints = append(endpoints, tempEndpoint) } @@ -243,7 +243,7 @@ func (p *BluecatProvider) Records(ctx context.Context) (endpoints []*endpoint.En if strings.Compare(rec.Name, txtRec.Name) == 0 { ep.Labels[endpoint.OwnerLabelKey], err = extractOwnerfromTXTRecord(txtRec.Properties) if err != nil { - return nil, errors.Wrapf(err, "owner not parsed correctly") + log.Debugf("External DNS Owner %s", err) } } } @@ -272,7 +272,7 @@ func (p *BluecatProvider) Records(ctx context.Context) (endpoints []*endpoint.En if strings.Compare(rec.Name, txtRec.Name) == 0 { ep.Labels[endpoint.OwnerLabelKey], err = extractOwnerfromTXTRecord(txtRec.Properties) if err != nil { - return nil, errors.Wrapf(err, "owner not parsed correctly") + log.Debugf("External DNS Owner %s", err) } } }