mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2026-05-05 06:36:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Changed ttlMaximum to MaxInt32 to allow compilation on 32bit machines

Browse Source 
In its current state, ttlMaximum causes make to fail build with error:
source/source.go:71:39: constant 4294967295 overflows int

Because math.MaxUint32 is an untyped integer constant it is converted
to type int when used as an interface param, type int is signed,
MaxUint32 is larger than MaxInt32 and causes the type int to overflow.

Converting ttlMaximum to MaxInt32 stops this overflow.
This commit is contained in:
Myles Gray 2019-07-23 17:40:57 +01:00
parent 411ab7f002
commit 231d0701aa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/source.go
View File

@ -49,7 +49,7 @@ const (
const (
ttlMinimum = 1
ttlMaximum = math.MaxUint32
ttlMaximum = math.MaxInt32
)
// Source defines the interface Endpoint sources should implement.