From 1ce3d4e7059ed117fce5594b37bfbec71d7b23f2 Mon Sep 17 00:00:00 2001 From: Ivan Ka <5395690+ivankatliarchuk@users.noreply.github.com> Date: Sat, 8 Nov 2025 12:16:52 +0000 Subject: [PATCH] fix(service): rollback nodeinformer for addevent handler (#5941) Signed-off-by: ivan katliarchuk --- source/service.go | 3 --- source/service_test.go | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/source/service.go b/source/service.go index ff4d45302..afc7289e7 100644 --- a/source/service.go +++ b/source/service.go @@ -896,9 +896,6 @@ func (sc *serviceSource) AddEventHandler(_ context.Context, handler func()) { if sc.listenEndpointEvents && sc.serviceTypeFilter.isRequired(v1.ServiceTypeNodePort, v1.ServiceTypeClusterIP) { _, _ = sc.endpointSlicesInformer.Informer().AddEventHandler(eventHandlerFunc(handler)) } - if sc.serviceTypeFilter.isRequired(v1.ServiceTypeNodePort) { - _, _ = sc.nodeInformer.Informer().AddEventHandler(eventHandlerFunc(handler)) - } } type serviceTypes struct { diff --git a/source/service_test.go b/source/service_test.go index b492cd57e..6d9e3a8d8 100644 --- a/source/service_test.go +++ b/source/service_test.go @@ -5126,11 +5126,11 @@ func TestServiceSource_AddEventHandler(t *testing.T) { { name: "AddEventHandler should trigger all event handlers when empty filter is provided", filter: []string{}, - times: 3, + times: 2, asserts: func(t *testing.T, s *serviceSource) { fakeServiceInformer.AssertNumberOfCalls(t, "Informer", 1) fakeEdpInformer.AssertNumberOfCalls(t, "Informer", 1) - fakeNodeInformer.AssertNumberOfCalls(t, "Informer", 1) + fakeNodeInformer.AssertNumberOfCalls(t, "Informer", 0) }, }, { @@ -5156,11 +5156,11 @@ func TestServiceSource_AddEventHandler(t *testing.T) { { name: "AddEventHandler should configure all service event handlers", filter: []string{string(v1.ServiceTypeNodePort)}, - times: 3, + times: 2, asserts: func(t *testing.T, s *serviceSource) { fakeServiceInformer.AssertNumberOfCalls(t, "Informer", 1) fakeEdpInformer.AssertNumberOfCalls(t, "Informer", 1) - fakeNodeInformer.AssertNumberOfCalls(t, "Informer", 1) + fakeNodeInformer.AssertNumberOfCalls(t, "Informer", 0) }, }, }