From 180afc67eaa88c08301eaeab9f64d05dd433cd95 Mon Sep 17 00:00:00 2001 From: Raffaele Di Fazio Date: Fri, 8 May 2020 19:08:16 +0200 Subject: [PATCH] it is okay to expose zoneids Signed-off-by: Raffaele Di Fazio --- provider/dyn/dyn.go | 2 +- provider/zone_id_filter.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/provider/dyn/dyn.go b/provider/dyn/dyn.go index bea6d9675..31aa89543 100644 --- a/provider/dyn/dyn.go +++ b/provider/dyn/dyn.go @@ -405,7 +405,7 @@ func (d *dynProviderState) buildLinkToRecord(ep *endpoint.Endpoint) string { return "" } var matchingZone = "" - for _, zone := range d.ZoneIDFilter.ZoneIDs { // FIXME this should not access directly the ZoneIDs + for _, zone := range d.ZoneIDFilter.ZoneIDs { if strings.HasSuffix(ep.DNSName, zone) { matchingZone = zone break diff --git a/provider/zone_id_filter.go b/provider/zone_id_filter.go index 39c3d9289..e15581f27 100644 --- a/provider/zone_id_filter.go +++ b/provider/zone_id_filter.go @@ -20,7 +20,7 @@ import "strings" // ZoneIDFilter holds a list of zone ids to filter by type ZoneIDFilter struct { - ZoneIDs []string // FIXME this was temporarily put as public to allow the dyn provider to compile + ZoneIDs []string } // NewZoneIDFilter returns a new ZoneIDFilter given a list of zone ids