From 17ca22c309c8ce0274be683c7a94cfd357a6f7b6 Mon Sep 17 00:00:00 2001 From: Michel Loiseleur Date: Mon, 19 Jun 2023 11:17:51 +0200 Subject: [PATCH] fix test on istio --- source/istio_virtualservice.go | 1 - source/istio_virtualservice_test.go | 8 +++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/source/istio_virtualservice.go b/source/istio_virtualservice.go index 2e8ecf0ed..e6e87e6f5 100644 --- a/source/istio_virtualservice.go +++ b/source/istio_virtualservice.go @@ -214,7 +214,6 @@ func (sc *virtualServiceSource) getGateway(ctx context.Context, gatewayStr strin log.Debugf("Gateway %s referenced by VirtualService %s/%s not found: %v", gatewayStr, virtualService.Namespace, virtualService.Name, err) return nil, nil } - return gateway, nil } diff --git a/source/istio_virtualservice_test.go b/source/istio_virtualservice_test.go index 1f4821064..551be6706 100644 --- a/source/istio_virtualservice_test.go +++ b/source/istio_virtualservice_test.go @@ -1751,7 +1751,13 @@ func TestVirtualServiceSourceGetGateway(t *testing.T) { } else { require.NoError(t, err) } - assert.Equalf(t, tt.want, got, "getGateway(%v, %v, %v)", tt.args.ctx, tt.args.gatewayStr, tt.args.virtualService) + if tt.want != nil && got != nil { + tt.want.Spec.ProtoReflect() + tt.want.Status.ProtoReflect() + assert.Equalf(t, tt.want, got, "getGateway(%v, %v, %v)", tt.args.ctx, tt.args.gatewayStr, tt.args.virtualService) + } else { + assert.Equalf(t, tt.want, got, "getGateway(%v, %v, %v)", tt.args.ctx, tt.args.gatewayStr, tt.args.virtualService) + } }) } }