Avoid shadowing package name (#410)

* chore: avoid shadowing package name

* fix: use constant format in call to Sprintf

* chore: try to make go1.9 work on travis

.travis.yml

@@ -7,6 +7,7 @@ language: go
 
 go:
 - 1.8
+- 1.9
 - tip
 
 matrix:
@@ -15,7 +16,7 @@ matrix:
 
 before_install:
 - go get github.com/mattn/goveralls
-- go get -u github.com/alecthomas/gometalinter
+- go get github.com/alecthomas/gometalinter
 
 install:
 - gometalinter --install

registry/txt.go

@@ -28,11 +28,14 @@ import (
 	"github.com/kubernetes-incubator/external-dns/provider"
 )
 
-var (
-	txtLabelRegex  = regexp.MustCompile("^\"heritage=external-dns,external-dns/owner=(.+)\"")
+const (
 	txtLabelFormat = "\"heritage=external-dns,external-dns/owner=%s\""
 )
 
+var (
+	txtLabelRegex = regexp.MustCompile("^\"heritage=external-dns,external-dns/owner=(.+)\"")
+)
+
 // TXTRegistry implements registry interface with ownership implemented via associated TXT records
 type TXTRegistry struct {
 	provider provider.Provider

source/fake.go

@@ -66,13 +66,13 @@ func (sc *fakeSource) Endpoints() ([]*endpoint.Endpoint, error) {
 }
 
 func (sc *fakeSource) generateEndpoint() (*endpoint.Endpoint, error) {
-	endpoint := endpoint.NewEndpoint(
+	ep := endpoint.NewEndpoint(
 		generateDNSName(4, sc.dnsName),
 		generateIPAddress(),
 		endpoint.RecordTypeA,
 	)
 
-	return endpoint, nil
+	return ep, nil
 }
 
 func generateIPAddress() string {