fix review comments and switch to spectral linter

.github/workflows/lint.yaml

@@ -29,14 +29,14 @@ jobs:
       with:
         go-version-file: go.mod
 
-    - name: Lint
+    - name: Lint go code
       uses: golangci/golangci-lint-action@v6
       with:
         args: --timeout=30m
         version: v1.60
 
-      shell: bash
+      # Run Spectral
-    - name: Run Vacuum
+    - name: Lint OpenAPI spec
-      run: |
+      uses: stoplightio/spectral-action@2ad0b9302e32a77c1caccf474a9b2191a8060d83 # v0.8.11
-        go run github.com/daveshanley/vacuum@latest lint -d api/webhook.yaml
+      with:
-      shell: bash
+        file_glob: 'api/*.yaml'

.spectral.yaml

@@ -0,0 +1 @@
+extends: ["spectral:oas"]

Makefile

@@ -60,8 +60,9 @@ licensecheck:
                exit 1; \
        fi
 
+# Requires to install spectral. See https://github.com/stoplightio/spectral
 oas-lint:
-	go run github.com/daveshanley/vacuum@latest lint -d api/webhook.yaml
+	spectral lint api/*.yaml
 
 # Run all the linters
 .PHONY: lint

api/webhook.yaml

@@ -1,7 +1,7 @@
 ---
 openapi: "3.0.0"
 info:
-  version: 0.14.0
+  version: v0.15.0
   title: External DNS Webhook Server
   description: >-
     Implements the external DNS webhook endpoints.
@@ -44,7 +44,7 @@ paths:
                   - example.com
         '500':
           description: |
-            Failed to provide the list of domains we serve.
+            Negociation failed.
 
   /records:
     get:

provider/webhook/webhook_test.go

@@ -162,6 +162,7 @@ func TestAdjustEndpoints(t *testing.T) {
 		}
 		j, _ := json.Marshal(endpoints)
 		w.Write(j)
+
 	}))
 	defer svr.Close()