mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2026-05-04 19:56:37 +02:00
Code Issues Projects Releases Wiki Activity

fix(tests): stabilize flaky list_wrap_indent frontend test (#7522)

Browse Source 
The test was failing intermittently in CI with "Element is not attached
to the DOM" at selectText(). The long text typed by writeToPad triggers
DOM re-renders in Etherpad, and on slower CI runners the div locator
could detach between resolve and action.

Switch to keyboard-based selection (Ctrl+A) via the existing
selectAllText helper, which doesn't depend on a specific DOM element
staying attached. Verified stable across 10 repeated runs on chromium.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
John McLear 2026-04-16 11:24:58 +01:00 committed by GitHub
parent 9542052343
commit 2a264eacc2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/tests/frontend-new/specs/list_wrap_indent.spec.ts
View File

@ -1,5 +1,5 @@
import {expect, test} from "@playwright/test";
import {clearPadContent, getPadBody, goToNewPad, writeToPad} from "../helper/padHelper";
import {clearPadContent, getPadBody, goToNewPad, selectAllText, writeToPad} from "../helper/padHelper";
test.beforeEach(async ({page}) => {
await goToNewPad(page);
@ -17,19 +17,20 @@ test.describe('numbered list wrapped line indentation', function () {
'indented to match the first line of the list item instead of snapping back to the left edge.';
await writeToPad(page, longText);
// Make it an ordered list
const $insertorderedlistButton = page.locator('.buttonicon-insertorderedlist');
await padBody.locator('div').first().selectText();
await $insertorderedlistButton.first().click();
// Select all content and make it an ordered list. Use Ctrl+A via the
// shared keyboard helper so we don't race against Etherpad re-rendering
// the line divs (which can detach locators and make `selectText()` flaky
// in CI when many lines of text have just been typed).
await selectAllText(page);
await page.locator('.buttonicon-insertorderedlist').first().click();
// Verify the list item has padding-left applied (not text-indent)
const ol = padBody.locator('ol').first();
await expect(ol).toBeVisible();
const paddingLeft = await ol.evaluate((el) => window.getComputedStyle(el).paddingLeft);
const textIndent = await ol.evaluate((el) => window.getComputedStyle(el).textIndent);
// padding-left should be used instead of text-indent for proper wrapping
// text-indent should be 0px (not used for indentation)
// padding-left should be used instead of text-indent for proper wrapping.
// text-indent should be 0px (not used for indentation).
const textIndent = await ol.evaluate((el) => window.getComputedStyle(el).textIndent);
expect(textIndent).toBe('0px');
});
});