element-web/test/unit-tests/theme-test.ts
Florian Duros be7be39d0f
Fix bundled font or custom font not applied after theme switch (#31591)
* refactor: transform `FontWater.onAction` to switch

* fix: reload font after switching theme

Fix #26248 #31588

When a theme is swiched, `clearCustomTheme` remove all css variables.
After the styles are re-applied but the custom fonts or emoji are not
re-applied.

* test: add test for `Action.ReloadFont`

* test: add missing tests for existing actions

* test(e2e): add tests to ensure that font and emoji stay unchanged

* Revert "fix: reload font after switching theme"

This reverts commit 2b0071af21c38bf2c86780356aa39d290e9d9148.

* Revert "refactor: transform `FontWater.onAction` to switch"

This reverts commit 411915860923230cabce3ad5498fb46696a9a65e.

* Revert "test: add test for `Action.ReloadFont`"

This reverts commit 31b3b224cd2c443663a2b9bba312a4140907a8ed.

* fix: don't remove custom emoji and cpd font when clearing custom theme

Fix #26248 #31588

When a theme is swiched, `clearCustomTheme` remove all css variables.
After the styles are re-applied but the custom fonts or emoji are not
re-applied.
This fix avoid the custom font and emoji to be removed.

* test: add tests
2026-01-05 16:14:08 +00:00

269 lines
10 KiB
TypeScript

/*
Copyright 2024 New Vector Ltd.
Copyright 2022 The Matrix.org Foundation C.I.C.
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
Please see LICENSE files in the repository root for full details.
*/
import SettingsStore from "../../src/settings/SettingsStore";
import { FontWatcher } from "../../src/settings/watchers/FontWatcher";
import { enumerateThemes, getOrderedThemes, setTheme } from "../../src/theme";
describe("theme", () => {
afterEach(() => {
jest.restoreAllMocks();
});
describe("setTheme", () => {
let lightTheme: HTMLStyleElement;
let darkTheme: HTMLStyleElement;
let lightCustomTheme: HTMLStyleElement;
let spyQuerySelectorAll: jest.MockInstance<NodeListOf<Element>, [selectors: string]>;
let spyClassList: jest.SpyInstance<void, string[], any>;
beforeAll(() => {
const meta = document.createElement("meta");
meta.name = "theme-color";
document.head.appendChild(meta);
});
beforeEach(() => {
const styles = ["light", "dark", "light-custom", "dark-custom"].map(
(theme) =>
({
dataset: {
mxTheme: theme,
},
disabled: true,
href: "fake URL",
onload: (): void => void 0,
}) as unknown as HTMLStyleElement,
);
lightTheme = styles[0];
darkTheme = styles[1];
lightCustomTheme = styles[2];
jest.spyOn(document.body, "style", "get").mockReturnValue([] as any);
spyQuerySelectorAll = jest.spyOn(document, "querySelectorAll").mockReturnValue(styles as any);
spyClassList = jest.spyOn(document.body.classList, "add");
});
afterEach(() => {
jest.useRealTimers();
});
it("should switch theme on onload call", async () => {
// When
await new Promise((resolve) => {
setTheme("light").then(resolve);
lightTheme.onload!({} as Event);
});
// Then
expect(spyQuerySelectorAll).toHaveBeenCalledWith("[data-mx-theme]");
expect(spyQuerySelectorAll).toHaveBeenCalledTimes(1);
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
expect(spyClassList).toHaveBeenCalledWith("cpd-theme-light");
});
it("should switch to dark", async () => {
// When
await new Promise((resolve) => {
setTheme("dark").then(resolve);
darkTheme.onload!({} as Event);
});
// Then
expect(spyClassList).toHaveBeenCalledWith("cpd-theme-dark");
});
it("should reject promise on onerror call", () => {
return expect(
new Promise((resolve) => {
setTheme("light").catch((e) => resolve(e));
lightTheme.onerror!("call onerror");
}),
).resolves.toBe("call onerror");
});
it("should switch theme if CSS are preloaded", async () => {
// When
jest.spyOn(document, "styleSheets", "get").mockReturnValue([lightTheme] as any);
await setTheme("light");
// Then
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
});
it("should switch theme if CSS is loaded during pooling", async () => {
// When
jest.useFakeTimers();
await new Promise((resolve) => {
setTheme("light").then(resolve);
jest.spyOn(document, "styleSheets", "get").mockReturnValue([lightTheme] as any);
jest.advanceTimersByTime(200);
});
// Then
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
});
it("should reject promise if pooling maximum value is reached", () => {
jest.useFakeTimers();
return new Promise((resolve) => {
setTheme("light").catch(resolve);
jest.advanceTimersByTime(200 * 10);
});
});
it("applies a custom Compound theme", async () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([
{
name: "blue",
compound: {
"--cpd-color-icon-accent-tertiary": "var(--cpd-color-blue-800)",
"--cpd-color-text-action-accent": "var(--cpd-color-blue-900)",
},
},
]);
const spy = jest.spyOn(document.head, "appendChild").mockImplementation();
await new Promise((resolve) => {
setTheme("custom-blue").then(resolve);
lightCustomTheme.onload!({} as Event);
});
expect(spy).toHaveBeenCalled();
expect(spy.mock.calls[0][0].textContent).toMatchSnapshot();
spy.mockRestore();
});
it("should handle 4-char rgba hex strings", async () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([
{
name: "blue",
colors: {
"sidebar-color": "#abcd",
},
},
]);
const spy = jest.fn();
jest.spyOn(document.body, "style", "get").mockReturnValue({
setProperty: spy,
} as any);
await new Promise((resolve) => {
setTheme("custom-blue").then(resolve);
lightCustomTheme.onload!({} as Event);
});
expect(spy).toHaveBeenCalledWith("--sidebar-color", "#abcd");
expect(spy).toHaveBeenCalledWith("--sidebar-color-0pct", "#aabbcc00");
expect(spy).toHaveBeenCalledWith("--sidebar-color-15pct", "#aabbcc21");
expect(spy).toHaveBeenCalledWith("--sidebar-color-50pct", "#aabbcc6f");
});
it("should handle 6-char rgb hex strings", async () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([
{
name: "blue",
colors: {
"sidebar-color": "#abcdef",
},
},
]);
const spy = jest.fn();
jest.spyOn(document.body, "style", "get").mockReturnValue({
setProperty: spy,
} as any);
await new Promise((resolve) => {
setTheme("custom-blue").then(resolve);
lightCustomTheme.onload!({} as Event);
});
expect(spy).toHaveBeenCalledWith("--sidebar-color", "#abcdef");
expect(spy).toHaveBeenCalledWith("--sidebar-color-0pct", "#abcdef00");
expect(spy).toHaveBeenCalledWith("--sidebar-color-15pct", "#abcdef26");
expect(spy).toHaveBeenCalledWith("--sidebar-color-50pct", "#abcdef80");
});
});
describe("enumerateThemes", () => {
it("should return a list of themes", () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([{ name: "pink" }]);
expect(enumerateThemes()).toEqual({
"light": "Light",
"light-high-contrast": "Light high contrast",
"dark": "Dark",
"custom-pink": "pink",
});
});
it("should be robust to malformed custom_themes values", () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([23] as any);
expect(enumerateThemes()).toEqual({
"light": "Light",
"light-high-contrast": "Light high contrast",
"dark": "Dark",
});
});
});
describe("getOrderedThemes", () => {
it("should return a list of themes in the correct order", () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([{ name: "Zebra Striped" }, { name: "Apple Green" }]);
expect(getOrderedThemes()).toEqual([
{ id: "light", name: "Light" },
{ id: "dark", name: "Dark" },
{ id: "custom-Apple Green", name: "Apple Green" },
{ id: "custom-Zebra Striped", name: "Zebra Striped" },
]);
});
});
describe("clearCustomTheme", () => {
beforeEach(() => {
// Reset document state
document.body.style.cssText = "";
document.head.querySelectorAll("style[title^='custom-theme-']").forEach((el) => el.remove());
});
it("should not remove font family custom properties", async () => {
// Mock theme elements
const lightTheme = {
dataset: { mxTheme: "light" },
disabled: true,
href: "fake URL",
onload: (): void => void 0,
} as unknown as HTMLStyleElement;
const removePropertySpy = jest.fn();
const styleObject = {
0: FontWatcher.FONT_FAMILY_CUSTOM_PROPERTY,
1: FontWatcher.EMOJI_FONT_FAMILY_CUSTOM_PROPERTY,
2: "--custom-color",
length: 3,
removeProperty: removePropertySpy,
};
jest.spyOn(document.body, "style", "get").mockReturnValue(styleObject as any);
jest.spyOn(document, "querySelectorAll").mockReturnValue([lightTheme] as any);
// Trigger clearCustomTheme via setTheme
await new Promise((resolve) => {
setTheme("light").then(resolve);
lightTheme.onload!({} as Event);
});
// Check that font properties were NOT removed
expect(removePropertySpy).not.toHaveBeenCalledWith(FontWatcher.FONT_FAMILY_CUSTOM_PROPERTY);
expect(removePropertySpy).not.toHaveBeenCalledWith(FontWatcher.EMOJI_FONT_FAMILY_CUSTOM_PROPERTY);
// But custom color should be removed
expect(removePropertySpy).toHaveBeenCalledWith("--custom-color");
});
});
});