mirror of
https://github.com/vector-im/element-web.git
synced 2025-12-17 07:11:10 +01:00
* Use EditInPlace for identity server picker. * Update test * Add a test for setting an ID server. * fix tests * Reformat other :not sections * forgot a comma * Update Apperance settings to use toggle switches. * Remove unused checkbox setting. * Remove unused import. * Update tests * lint * update apperance screenshot * Begin replacing settings * Refactor RoomPublishSetting * Remove LabelledToggleSwitch * Refactor SettingsFlag to use SettingsToggleInput * Refactor CreateRoomDialog to use SettingsToggleInput * Refactor DeclineAndBlockInviteDialog to use SettingsToggleInput * Update DevtoolsDialog * Refactor ReportRoomDialog to use SettingsToggle * Update RoomUpgradeWarningDialog to use SettingsToggleInput * Update WidgetCapabilitiesPromptDialog to use SettingsToggleInput * Update trivial switchovers * Update Notifications settings to use SettingsFlag where possible * Update RoomPublishSetting and SpaceSettingVisibilityTab to use SettingsToggleInput with a warning * revert changes to field * Updated screenshots * Prevent accidental submits * Replace test ID tests * Create new snapshot tests * Add screenshot test for DeclineAndBlockDialog * Add screenshot for create room dialog. * Add devtools test * Add upgrade rooms test * Add widget capabilites prompt test * Fix spec * Add a test for the live location sharing prompt. * fix copyright * Add tests for notification settings * Add tests for user security tab. * Add test for room security tab. * Add test for video settings tab. * remove .only * Test creating a video room * Mask the IM name in the header. * Add spaces vis tab test. * Fixup unit tests to check correct attributes. * Various fixes to components for tests. * lint * Update compound * update setting names * Cleanup tests prettier Updates some more playwright tests Update more snapshots Update switch more fixes drop .only last screenshot round fix video room flake Remove console.logs Remove roomId from devtools view. lint final screenshot * Add playwright tests * import pages/ remove duplicate create-room * Update screenshots * Fix accessibility for devtools * Disable region test * Fixup headers * remove extra test * Fix permissions dialog * fixup tests * update snapshot * Update jest tests * Clear up playwright tests * update widget screenshot * Fix wrong snaps from using wrong compound version * Revert mistaken s/checkbox/switch/ * lint lint * Update headings * fix snap * remove unused * update snapshot * update tab screenshot * Update snapshots * Fix margins * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Delint Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshot Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshot Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
505 lines
20 KiB
TypeScript
505 lines
20 KiB
TypeScript
/*
|
|
Copyright 2024 New Vector Ltd.
|
|
Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import React from "react";
|
|
import { fireEvent, render, screen, within } from "jest-matrix-react";
|
|
import { type Room, JoinRule, MatrixError, Preset, Visibility } from "matrix-js-sdk/src/matrix";
|
|
|
|
import CreateRoomDialog from "../../../../../src/components/views/dialogs/CreateRoomDialog";
|
|
import { flushPromises, getMockClientWithEventEmitter, mkSpace, mockClientMethodsUser } from "../../../../test-utils";
|
|
import SettingsStore from "../../../../../src/settings/SettingsStore";
|
|
import { UIFeature } from "../../../../../src/settings/UIFeature";
|
|
|
|
describe("<CreateRoomDialog />", () => {
|
|
const userId = "@alice:server.org";
|
|
|
|
const getE2eeEnableToggleInputElement = () => screen.getByLabelText("Enable end-to-end encryption");
|
|
|
|
let mockClient: ReturnType<typeof getMockClientWithEventEmitter>;
|
|
beforeEach(() => {
|
|
mockClient = getMockClientWithEventEmitter({
|
|
...mockClientMethodsUser(userId),
|
|
getDomain: jest.fn().mockReturnValue("server.org"),
|
|
getClientWellKnown: jest.fn(),
|
|
doesServerForceEncryptionForPreset: jest.fn(),
|
|
// make every alias available
|
|
getRoomIdForAlias: jest.fn().mockRejectedValue(new MatrixError({ errcode: "M_NOT_FOUND" })),
|
|
});
|
|
mockClient.doesServerForceEncryptionForPreset.mockResolvedValue(false);
|
|
mockClient.getClientWellKnown.mockReturnValue({});
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
const getComponent = (props = {}) => render(<CreateRoomDialog onFinished={jest.fn()} {...props} />);
|
|
|
|
it("should default to private room", async () => {
|
|
getComponent();
|
|
await flushPromises();
|
|
|
|
expect(screen.getByText("Create a private room")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should use defaultName from props", async () => {
|
|
const defaultName = "My test room";
|
|
getComponent({ defaultName });
|
|
await flushPromises();
|
|
|
|
expect(screen.getByLabelText("Name")).toHaveDisplayValue(defaultName);
|
|
});
|
|
|
|
it("should include topic in room creation options", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
const topic = "This is a test topic";
|
|
|
|
// Set room name and topic.
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Room with topic" } });
|
|
fireEvent.change(screen.getByLabelText("Topic (optional)"), { target: { value: topic } });
|
|
|
|
// Create the room.
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(
|
|
true,
|
|
expect.objectContaining({
|
|
name: "Room with topic",
|
|
topic,
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("should include no federate option in room creation options when enabled", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
// Set room name, and disable federation.
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "NoFederate Room" } });
|
|
fireEvent.click(screen.getByLabelText("Block anyone not part of server.org from ever joining this room."));
|
|
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(
|
|
true,
|
|
expect.objectContaining({
|
|
name: "NoFederate Room",
|
|
createOpts: expect.objectContaining({
|
|
creation_content: expect.objectContaining({
|
|
"m.federate": false,
|
|
}),
|
|
}),
|
|
}),
|
|
);
|
|
});
|
|
|
|
describe("for a private room", () => {
|
|
// default behaviour is a private room
|
|
|
|
it("should use server .well-known default for encryption setting", async () => {
|
|
// default to off
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
"io.element.e2ee": {
|
|
default: false,
|
|
},
|
|
});
|
|
getComponent();
|
|
await flushPromises();
|
|
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeDisabled();
|
|
expect(
|
|
screen.getByText(
|
|
"Your server admin has disabled end-to-end encryption by default in private rooms & Direct Messages.",
|
|
),
|
|
).toBeDefined();
|
|
});
|
|
|
|
it("should use server .well-known force_disable for encryption setting", async () => {
|
|
// force to off
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
"io.element.e2ee": {
|
|
default: true,
|
|
force_disable: true,
|
|
},
|
|
});
|
|
getComponent();
|
|
await flushPromises();
|
|
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).toBeDisabled();
|
|
expect(
|
|
screen.getByText(
|
|
"Your server admin has disabled end-to-end encryption by default in private rooms & Direct Messages.",
|
|
),
|
|
).toBeDefined();
|
|
});
|
|
|
|
it("should use defaultEncrypted prop", async () => {
|
|
// default to off in server wk
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
"io.element.e2ee": {
|
|
default: false,
|
|
},
|
|
});
|
|
// but pass defaultEncrypted prop
|
|
getComponent({ defaultEncrypted: true });
|
|
await flushPromises();
|
|
// encryption enabled
|
|
expect(getE2eeEnableToggleInputElement()).toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeDisabled();
|
|
});
|
|
|
|
it("should use defaultEncrypted prop when it is false", async () => {
|
|
// default to off in server wk
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
"io.element.e2ee": {
|
|
default: true,
|
|
},
|
|
});
|
|
// but pass defaultEncrypted prop
|
|
getComponent({ defaultEncrypted: false });
|
|
await flushPromises();
|
|
// encryption disabled
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeChecked();
|
|
// not forced to off
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeDisabled();
|
|
});
|
|
|
|
it("should override defaultEncrypted when server .well-known forces disabled encryption", async () => {
|
|
// force to off
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
"io.element.e2ee": {
|
|
force_disable: true,
|
|
},
|
|
});
|
|
getComponent({ defaultEncrypted: true });
|
|
await flushPromises();
|
|
|
|
// server forces encryption to disabled, even though defaultEncrypted is false
|
|
expect(getE2eeEnableToggleInputElement()).not.toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).toBeDisabled();
|
|
expect(
|
|
screen.getByText(
|
|
"Your server admin has disabled end-to-end encryption by default in private rooms & Direct Messages.",
|
|
),
|
|
).toBeDefined();
|
|
});
|
|
|
|
it("should override defaultEncrypted when server forces enabled encryption", async () => {
|
|
mockClient.doesServerForceEncryptionForPreset.mockResolvedValue(true);
|
|
getComponent({ defaultEncrypted: false });
|
|
await flushPromises();
|
|
|
|
// server forces encryption to enabled, even though defaultEncrypted is true
|
|
expect(getE2eeEnableToggleInputElement()).toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).toBeDisabled();
|
|
expect(screen.getByText("Your server requires encryption to be enabled in private rooms.")).toBeDefined();
|
|
});
|
|
|
|
it("should enable encryption toggle and disable field when server forces encryption", async () => {
|
|
mockClient.doesServerForceEncryptionForPreset.mockResolvedValue(true);
|
|
getComponent();
|
|
|
|
await flushPromises();
|
|
expect(getE2eeEnableToggleInputElement()).toBeChecked();
|
|
expect(getE2eeEnableToggleInputElement()).toBeDisabled();
|
|
|
|
expect(screen.getByText("Your server requires encryption to be enabled in private rooms.")).toBeDefined();
|
|
});
|
|
|
|
it("should warn when trying to create a room with an invalid form", async () => {
|
|
const onFinished = jest.fn();
|
|
getComponent({ onFinished });
|
|
await flushPromises();
|
|
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
// didn't submit room
|
|
expect(onFinished).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should create a private room", async () => {
|
|
const onFinished = jest.fn();
|
|
const { asFragment } = getComponent({ onFinished });
|
|
await flushPromises();
|
|
expect(asFragment()).toMatchSnapshot();
|
|
|
|
const roomName = "Test Room Name";
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: roomName } });
|
|
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(true, {
|
|
createOpts: {},
|
|
name: roomName,
|
|
encryption: true,
|
|
parentSpace: undefined,
|
|
roomType: undefined,
|
|
});
|
|
});
|
|
|
|
it("should render not the advanced options when UI.advancedSettings is disabled", async () => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation(
|
|
(setting) => setting !== UIFeature.AdvancedSettings,
|
|
);
|
|
const { asFragment } = getComponent();
|
|
await flushPromises();
|
|
expect(asFragment()).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
describe("for a knock room", () => {
|
|
describe("when feature is disabled", () => {
|
|
it("should not have the option to create a knock room", async () => {
|
|
jest.spyOn(SettingsStore, "getValue").mockReturnValue(false);
|
|
getComponent();
|
|
fireEvent.click(screen.getByLabelText("Room visibility"));
|
|
expect(screen.queryByRole("option", { name: "Ask to join" })).not.toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
describe("when feature is enabled", () => {
|
|
const onFinished = jest.fn();
|
|
const roomName = "Test Room Name";
|
|
|
|
beforeEach(async () => {
|
|
onFinished.mockReset();
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation(
|
|
(setting) => setting === "feature_ask_to_join",
|
|
);
|
|
getComponent({ onFinished });
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: roomName } });
|
|
fireEvent.click(screen.getByLabelText("Room visibility"));
|
|
fireEvent.click(screen.getByRole("option", { name: "Ask to join" }));
|
|
});
|
|
|
|
it("should have a heading", () => {
|
|
expect(screen.getByRole("heading")).toHaveTextContent("Create a room");
|
|
});
|
|
|
|
it("should have a hint", () => {
|
|
expect(
|
|
screen.getByText(
|
|
"Anyone can request to join, but admins or moderators need to grant access. You can change this later.",
|
|
),
|
|
).toBeInTheDocument();
|
|
});
|
|
|
|
it("should create a knock room with private visibility", async () => {
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
expect(onFinished).toHaveBeenCalledWith(true, {
|
|
createOpts: {
|
|
visibility: Visibility.Private,
|
|
},
|
|
name: roomName,
|
|
encryption: true,
|
|
joinRule: JoinRule.Knock,
|
|
parentSpace: undefined,
|
|
roomType: undefined,
|
|
});
|
|
});
|
|
|
|
it("should create a knock room with public visibility", async () => {
|
|
fireEvent.click(
|
|
screen.getByRole("switch", { name: "Make this room visible in the public room directory." }),
|
|
);
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
expect(onFinished).toHaveBeenCalledWith(true, {
|
|
createOpts: {
|
|
visibility: Visibility.Public,
|
|
},
|
|
name: roomName,
|
|
encryption: true,
|
|
joinRule: JoinRule.Knock,
|
|
parentSpace: undefined,
|
|
roomType: undefined,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("for a public room", () => {
|
|
it("should set join rule to public defaultPublic is truthy", async () => {
|
|
const onFinished = jest.fn();
|
|
getComponent({ defaultPublic: true, onFinished });
|
|
await flushPromises();
|
|
|
|
expect(screen.getByText("Create a public room")).toBeInTheDocument();
|
|
|
|
// e2e section is not rendered
|
|
expect(screen.queryByText("Enable end-to-end encryption")).not.toBeInTheDocument();
|
|
|
|
const roomName = "Test Room Name";
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: roomName } });
|
|
});
|
|
|
|
it("should not create a public room without an alias", async () => {
|
|
const onFinished = jest.fn();
|
|
getComponent({ onFinished });
|
|
await flushPromises();
|
|
|
|
// set to public
|
|
fireEvent.click(screen.getByLabelText("Room visibility"));
|
|
fireEvent.click(screen.getByText("Public room"));
|
|
expect(within(screen.getByLabelText("Room visibility")).findByText("Public room")).toBeTruthy();
|
|
expect(screen.getByText("Create a public room")).toBeInTheDocument();
|
|
|
|
// set name
|
|
const roomName = "Test Room Name";
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: roomName } });
|
|
|
|
// try to create the room
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
// alias field invalid
|
|
expect(screen.getByLabelText("Room address").parentElement!).toHaveClass("mx_Field_invalid");
|
|
|
|
// didn't submit
|
|
expect(onFinished).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should create a public room", async () => {
|
|
const onFinished = jest.fn();
|
|
getComponent({ onFinished, defaultPublic: true });
|
|
await flushPromises();
|
|
|
|
// set name
|
|
const roomName = "Test Room Name";
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: roomName } });
|
|
|
|
const roomAlias = "test";
|
|
|
|
fireEvent.change(screen.getByLabelText("Room address"), { target: { value: roomAlias } });
|
|
|
|
// try to create the room
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(true, {
|
|
createOpts: {
|
|
preset: Preset.PublicChat,
|
|
room_alias_name: roomAlias,
|
|
visibility: Visibility.Public,
|
|
},
|
|
name: roomName,
|
|
guestAccess: false,
|
|
parentSpace: undefined,
|
|
roomType: undefined,
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("for a room in a space", () => {
|
|
let parentSpace: Room;
|
|
beforeEach(() => {
|
|
parentSpace = mkSpace(mockClient, "!space:server") as unknown as Room;
|
|
});
|
|
|
|
it("should create a room with restricted join rule when selected", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog parentSpace={parentSpace} onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
// Set room name and visibility.
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Restricted Room" } });
|
|
fireEvent.click(screen.getByLabelText("Room visibility"));
|
|
fireEvent.click(screen.getByRole("option", { name: "Visible to space members" }));
|
|
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(
|
|
true,
|
|
expect.objectContaining({
|
|
name: "Restricted Room",
|
|
joinRule: JoinRule.Restricted,
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("should create a room with public join rule when selected", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog parentSpace={parentSpace} onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
// Set room name and visibility. Rooms in spaces also need an address.
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Public Room" } });
|
|
fireEvent.click(screen.getByLabelText("Room visibility"));
|
|
fireEvent.click(screen.getByRole("option", { name: "Public room" }));
|
|
fireEvent.change(screen.getByLabelText("Room address"), { target: { value: "testroom" } });
|
|
|
|
// Create the room.
|
|
fireEvent.click(screen.getByText("Create room"));
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(
|
|
true,
|
|
expect.objectContaining({
|
|
name: "Public Room",
|
|
createOpts: expect.objectContaining({
|
|
room_alias_name: "testroom",
|
|
visibility: Visibility.Public,
|
|
preset: Preset.PublicChat,
|
|
}),
|
|
guestAccess: false,
|
|
roomType: undefined,
|
|
}),
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("keyboard shortcuts", () => {
|
|
it("should submit the form when Enter is pressed", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
// Simulate pressing the Enter key.
|
|
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Keyboard Room" } });
|
|
fireEvent.keyDown(screen.getByLabelText("Name"), { key: "Enter", code: "Enter", charCode: 13 });
|
|
|
|
await flushPromises();
|
|
|
|
expect(onFinished).toHaveBeenCalledWith(
|
|
true,
|
|
expect.objectContaining({
|
|
name: "Keyboard Room",
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("should cancel the dialog when Escape is pressed", async () => {
|
|
const onFinished = jest.fn();
|
|
render(<CreateRoomDialog onFinished={onFinished} />);
|
|
await flushPromises();
|
|
|
|
// Simulate pressing the Escape key.
|
|
fireEvent.keyDown(screen.getByLabelText("Name"), { key: "Escape", code: "Escape", charCode: 27 });
|
|
|
|
await flushPromises();
|
|
|
|
// BaseDialog passes no arguments, but DialogButtons pass false - might not be desirable?
|
|
expect(onFinished).toHaveBeenCalled();
|
|
const callArgs = onFinished.mock.calls[0];
|
|
expect(callArgs.length === 0 || callArgs[0] === false).toBe(true);
|
|
});
|
|
});
|
|
});
|