mirror of
https://github.com/vector-im/element-web.git
synced 2025-11-10 13:11:09 +01:00
* Fix enabling key backup not working if there is an untrusted key backup on the server. * lint * Add test for trust situations. * remove conditional * Update src/components/viewmodels/settings/encryption/KeyStoragePanelViewModel.ts Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Update src/components/viewmodels/settings/encryption/KeyStoragePanelViewModel.ts Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> --------- Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
132 lines
4.7 KiB
TypeScript
132 lines
4.7 KiB
TypeScript
/*
|
|
Copyright 2025 New Vector Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import { renderHook } from "jest-matrix-react";
|
|
import { act } from "react";
|
|
import { mocked } from "jest-mock";
|
|
|
|
import type { MatrixClient } from "matrix-js-sdk/src/matrix";
|
|
import type { BackupTrustInfo, KeyBackupCheck, KeyBackupInfo } from "matrix-js-sdk/src/crypto-api";
|
|
import { useKeyStoragePanelViewModel } from "../../../../../../src/components/viewmodels/settings/encryption/KeyStoragePanelViewModel";
|
|
import { createTestClient, withClientContextRenderOptions } from "../../../../../test-utils";
|
|
|
|
describe("KeyStoragePanelViewModel", () => {
|
|
let matrixClient: MatrixClient;
|
|
|
|
beforeEach(() => {
|
|
matrixClient = createTestClient();
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
it("should update the pending value immediately", async () => {
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
act(() => {
|
|
result.current.setEnabled(true);
|
|
});
|
|
expect(result.current.isEnabled).toBe(true);
|
|
expect(result.current.busy).toBe(true);
|
|
});
|
|
|
|
it("should call resetKeyBackup if there is no backup currently", async () => {
|
|
mocked(matrixClient.getCrypto()!.checkKeyBackupAndEnable).mockResolvedValue(null);
|
|
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
|
|
await result.current.setEnabled(true);
|
|
expect(mocked(matrixClient.getCrypto()!.resetKeyBackup)).toHaveBeenCalled();
|
|
});
|
|
|
|
it.each<BackupTrustInfo>([
|
|
{ trusted: true, matchesDecryptionKey: false },
|
|
{ trusted: false, matchesDecryptionKey: true },
|
|
{ trusted: true, matchesDecryptionKey: true },
|
|
])("should not call resetKeyBackup if there is a backup currently and it is trusted", async (trustInfo) => {
|
|
mocked(matrixClient.getCrypto()!.checkKeyBackupAndEnable).mockResolvedValue({
|
|
backupInfo: {
|
|
version: "1",
|
|
algorithm: "foobar",
|
|
auth_data: {
|
|
public_key: "foobar",
|
|
},
|
|
},
|
|
trustInfo,
|
|
});
|
|
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
|
|
await result.current.setEnabled(true);
|
|
expect(mocked(matrixClient.getCrypto()!.resetKeyBackup)).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should call resetKeyBackup if there is a backup currently but it is not trusted", async () => {
|
|
mocked(matrixClient.getCrypto()!.checkKeyBackupAndEnable).mockResolvedValue({
|
|
backupInfo: {
|
|
version: "1",
|
|
algorithm: "foobar",
|
|
auth_data: {
|
|
public_key: "foobar",
|
|
},
|
|
},
|
|
trustInfo: {
|
|
trusted: false,
|
|
matchesDecryptionKey: false,
|
|
},
|
|
});
|
|
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
|
|
await result.current.setEnabled(true);
|
|
expect(mocked(matrixClient.getCrypto()!.resetKeyBackup)).toHaveBeenCalled();
|
|
});
|
|
|
|
it("should set account data flag when enabling", async () => {
|
|
mocked(matrixClient.getCrypto()!.checkKeyBackupAndEnable).mockResolvedValue(null);
|
|
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
|
|
await result.current.setEnabled(true);
|
|
expect(mocked(matrixClient.setAccountData)).toHaveBeenCalledWith("m.org.matrix.custom.backup_disabled", {
|
|
disabled: false,
|
|
});
|
|
});
|
|
|
|
it("should delete key storage when disabling", async () => {
|
|
mocked(matrixClient.getCrypto()!.checkKeyBackupAndEnable).mockResolvedValue({} as KeyBackupCheck);
|
|
mocked(matrixClient.getCrypto()!.getKeyBackupInfo).mockResolvedValue({ version: "99" } as KeyBackupInfo);
|
|
|
|
const { result } = renderHook(
|
|
() => useKeyStoragePanelViewModel(),
|
|
withClientContextRenderOptions(matrixClient),
|
|
);
|
|
|
|
await result.current.setEnabled(false);
|
|
|
|
expect(mocked(matrixClient.getCrypto()!.disableKeyStorage)).toHaveBeenCalled();
|
|
expect(mocked(matrixClient.setAccountData)).toHaveBeenCalledWith("m.org.matrix.custom.backup_disabled", {
|
|
disabled: true,
|
|
});
|
|
});
|
|
});
|