mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2025-12-26 03:31:56 +01:00
Code Issues Projects Releases Wiki Activity

try fix RoomHeader tests again by also mocking useParticipants

Browse Source
This commit is contained in:
David Langley 2025-08-27 16:22:53 +01:00
parent c45ad3063f
commit f83093cc44
2 changed files with 31 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hooks/useCall.ts
View File

@ -42,11 +42,10 @@ export const useConnectionState = (call: Call | null): ConnectionState =>
);
export const useParticipants = (call: Call | null): Map<RoomMember, Set<string>> => {
const participants = call?.participants;
return useTypedEventEmitterState(
call ?? undefined,
CallEvent.Participants,
useCallback((state) => state ?? participants ?? new Map(), [participants]),
useCallback((state) => state ?? call?.participants ?? new Map(), [call]),
);
};

42
test/unit-tests/components/views/rooms/RoomHeader/RoomHeader-test.tsx
View File

@ -554,7 +554,9 @@ describe("RoomHeader", () => {
});
it("join button is shown if there is an ongoing call", async () => {
mockRoomMembers(room, 3);
const members = mockRoomMembers(room, 3);
const participants = mockParticipants(members);
jest.spyOn(UseCall, "useParticipants").mockReturnValue(participants);
jest.spyOn(UseCall, "useParticipantCount").mockReturnValue(3);
render(<RoomHeader room={room} />, getWrapper());
const joinButton = getByLabelText(document.body, "Join");
@ -562,7 +564,9 @@ describe("RoomHeader", () => {
});
it("join button is disabled if there is an other ongoing call", async () => {
mockRoomMembers(room, 3);
const members = mockRoomMembers(room, 3);
const participants = mockParticipants(members);
jest.spyOn(UseCall, "useParticipants").mockReturnValue(participants);
jest.spyOn(UseCall, "useParticipantCount").mockReturnValue(3);
jest.spyOn(CallStore.prototype, "connectedCalls", "get").mockReturnValue(
new Set([{ roomId: "some_other_room" } as Call]),
@ -582,7 +586,9 @@ describe("RoomHeader", () => {
});
it("close lobby button is shown if there is an ongoing call but we are viewing the lobby", async () => {
mockRoomMembers(room, 3);
const members = mockRoomMembers(room, 3);
const participants = mockParticipants(members);
jest.spyOn(UseCall, "useParticipants").mockReturnValue(participants);
jest.spyOn(UseCall, "useParticipantCount").mockReturnValue(3);
jest.spyOn(SdkContextClass.instance.roomViewStore, "isViewingCall").mockReturnValue(true);
@ -792,20 +798,32 @@ describe("RoomHeader", () => {
/**
*
* @param count the number of users to create
* @returns the created members
*/
function mockRoomMembers(room: Room, count: number) {
const members = Array(count)
.fill(0)
.map((_, index) => ({
userId: `@user-${index}:example.org`,
name: `Member ${index}`,
rawDisplayName: `Member ${index}`,
roomId: room.roomId,
membership: KnownMembership.Join,
getAvatarUrl: () => `mxc://avatar.url/user-${index}.png`,
getMxcAvatarUrl: () => `mxc://avatar.url/user-${index}.png`,
}));
.map((_, index) => {
const userId = `@user-${index}:example.org`;
const member = new RoomMember(room.roomId, userId);
member.name = `Member ${index}`;
member.rawDisplayName = `Member ${index}`;
member.membership = KnownMembership.Join;
member.getAvatarUrl = () => `mxc://avatar.url/user-${index}.png`;
member.getMxcAvatarUrl = () => `mxc://avatar.url/user-${index}.png`;
return member;
});
room.currentState.setJoinedMemberCount(members.length);
room.getJoinedMembers = jest.fn().mockReturnValue(members);
return members;
}
/**
* Creates a participants map from room members
* @param members the room members to convert to participants
* @returns Map of participants with device sets
*/
function mockParticipants(members: RoomMember[]): Map<RoomMember, Set<string>> {
return new Map(members.map((member, index) => [member, new Set([`device${index + 1}`])]));
}