From ef69c0ddc709f8bc965fa44199f15e893b8606e7 Mon Sep 17 00:00:00 2001 From: Robin Date: Tue, 11 Feb 2025 15:28:29 +0700 Subject: [PATCH] Restore the accessibility role on call views (#29225) This was mistakenly removed in a370a5cfa43. You can tell it was unintentional because the 'role' variable was just left unused. --- src/components/views/voip/CallView.tsx | 2 +- test/unit-tests/components/views/voip/CallView-test.tsx | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/components/views/voip/CallView.tsx b/src/components/views/voip/CallView.tsx index d45554d08f..78249f56de 100644 --- a/src/components/views/voip/CallView.tsx +++ b/src/components/views/voip/CallView.tsx @@ -58,7 +58,7 @@ const JoinCallView: FC = ({ room, resizing, call, skipLobby, await Promise.all(calls.map(async (call) => await call.disconnect())); }, []); return ( -
+
{ client.reEmitter.stopReEmitting(room, [RoomStateEvent.Events]); }); - const renderView = async (skipLobby = false): Promise => { - render(); + const renderView = async (skipLobby = false, role: string | undefined = undefined): Promise => { + render(); await act(() => Promise.resolve()); // Let effects settle }; @@ -96,6 +96,11 @@ describe("CallView", () => { WidgetMessagingStore.instance.stopMessaging(widget, room.roomId); }); + it("accepts an accessibility role", async () => { + await renderView(undefined, "main"); + screen.getByRole("main"); + }); + it("calls clean on mount", async () => { const cleanSpy = jest.spyOn(call, "clean"); await renderView();