From dae5b6b43b6a721e28f72d26a3b7449e8f1a5f8b Mon Sep 17 00:00:00 2001 From: Will Hunt Date: Mon, 27 Oct 2025 13:08:31 +0000 Subject: [PATCH] Remove allowVoipWithNoMedia feature flag (#31087) * Remove allowVoipWithNoMedia feature flag * whoops * remove a string --- src/i18n/strings/en_EN.json | 1 - src/models/Call.ts | 4 ---- src/settings/Settings.tsx | 11 ----------- test/unit-tests/models/Call-test.ts | 22 ---------------------- 4 files changed, 38 deletions(-) diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 3ba40d89fe..a54a0cc0bc 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1474,7 +1474,6 @@ "upload_file": "Upload a file" }, "labs": { - "allow_screen_share_only_mode": "Allow screen share only mode", "ask_to_join": "Enable ask to join", "automatic_debug_logs": "Automatically send debug logs on any error", "automatic_debug_logs_decryption": "Automatically send debug logs on decryption errors", diff --git a/src/models/Call.ts b/src/models/Call.ts index 356aef1f3b..a5fbc8d0bd 100644 --- a/src/models/Call.ts +++ b/src/models/Call.ts @@ -704,10 +704,6 @@ export class ElementCall extends Call { params.append("allowIceFallback", "true"); } - if (SettingsStore.getValue("feature_allow_screen_share_only_mode")) { - params.append("allowVoipWithNoMedia", "true"); - } - // Set custom fonts if (SettingsStore.getValue("useSystemFont")) { SettingsStore.getValue("systemFont") diff --git a/src/settings/Settings.tsx b/src/settings/Settings.tsx index f390544abe..78758ea277 100644 --- a/src/settings/Settings.tsx +++ b/src/settings/Settings.tsx @@ -222,7 +222,6 @@ export interface Settings { "feature_element_call_video_rooms": IFeature; "feature_group_calls": IFeature; "feature_disable_call_per_sender_encryption": IFeature; - "feature_allow_screen_share_only_mode": IFeature; "feature_location_share_live": IFeature; "feature_dynamic_room_predecessors": IFeature; "feature_render_reaction_images": IFeature; @@ -644,16 +643,6 @@ export const SETTINGS: Settings = { displayName: _td("labs|feature_disable_call_per_sender_encryption"), default: false, }, - "feature_allow_screen_share_only_mode": { - isFeature: true, - labsGroup: LabGroup.VoiceAndVideo, - supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS_WITH_CONFIG_PRIORITISED, - supportedLevelsAreOrdered: true, - description: _td("labs|under_active_development"), - displayName: _td("labs|allow_screen_share_only_mode"), - controller: new ReloadOnChangeController(), - default: false, - }, "feature_location_share_live": { isFeature: true, labsGroup: LabGroup.Messaging, diff --git a/test/unit-tests/models/Call-test.ts b/test/unit-tests/models/Call-test.ts index 5d83aa335d..dbf2dca974 100644 --- a/test/unit-tests/models/Call-test.ts +++ b/test/unit-tests/models/Call-test.ts @@ -642,28 +642,6 @@ describe("ElementCall", () => { expect(urlParams.get("analyticsID")).toBeFalsy(); }); - it("passes feature_allow_screen_share_only_mode setting to allowVoipWithNoMedia url param", async () => { - // Now test with the preference set to true - const originalGetValue = SettingsStore.getValue; - SettingsStore.getValue = (name: SettingKey, roomId: string | null = null, excludeDefault = false): any => { - switch (name) { - case "feature_allow_screen_share_only_mode": - return true; - default: - return excludeDefault - ? originalGetValue(name, roomId, excludeDefault) - : originalGetValue(name, roomId, excludeDefault); - } - }; - ElementCall.create(room); - const call = Call.get(room); - if (!(call instanceof ElementCall)) throw new Error("Failed to create call"); - - const urlParams = new URLSearchParams(new URL(call.widget.url).hash.slice(1)); - expect(urlParams.get("allowVoipWithNoMedia")).toBe("true"); - SettingsStore.getValue = originalGetValue; - }); - it("passes empty analyticsID if the id is not in the account data", async () => { client.getAccountData.mockImplementation((eventType: string) => { if (eventType === PosthogAnalytics.ANALYTICS_EVENT_TYPE) {