mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2026-05-05 20:26:19 +02:00
Code Issues Projects Releases Wiki Activity

getByRole is slow on large trees, use getByText (#29331)

Browse Source
This commit is contained in:
David Langley 2025-02-21 13:45:52 +00:00 committed by GitHub
parent 22943ee06a
commit d8904a6e56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit-tests/components/views/settings/AddRemoveThreepids-test.tsx
View File

@ -172,7 +172,7 @@ describe("AddRemoveThreepids", () => {
const countryDropdown = await screen.findByRole("button", { name: /Country Dropdown/ });
await userEvent.click(countryDropdown);
const gbOption = screen.getByRole("option", { name: "🇬🇧 United Kingdom (+44)" });
const gbOption = screen.getByText("United Kingdom (+44)");
await userEvent.click(gbOption);
const input = screen.getByRole("textbox", { name: "Phone Number" });
@ -511,7 +511,7 @@ describe("AddRemoveThreepids", () => {
const countryDropdown = screen.getByRole("button", { name: /Country Dropdown/ });
await userEvent.click(countryDropdown);
const gbOption = screen.getByRole("option", { name: "🇬🇧 United Kingdom (+44)" });
const gbOption = screen.getByText("United Kingdom (+44)");
await userEvent.click(gbOption);
const input = screen.getByRole("textbox", { name: "Phone Number" });