mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2025-09-19 12:41:24 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #15050 from vector-im/jryans/testing-code-review

Browse Source 
Add testing to review guidelines
This commit is contained in:
J. Ryan Stinnett 2020-08-26 17:58:30 +01:00 committed by GitHub
commit cb94a89411
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/review.md
View File

@ -14,6 +14,7 @@ When reviewing code, here are some things we look for and also things we avoid:
* Performance * Performance
* Accessibility * Accessibility
* Security * Security
* Quality via automated and manual testing
* Comments and documentation where needed * Comments and documentation where needed
* Sharing knowledge of different areas among the team * Sharing knowledge of different areas among the team
* Ensuring it's something we're comfortable maintaining for the long term * Ensuring it's something we're comfortable maintaining for the long term
@ -34,6 +35,7 @@ When reviewing code, here are some things we look for and also things we avoid:
* Reviewers should be explicit about required versus optional changes * Reviewers should be explicit about required versus optional changes
* Reviews are conversations and the PR author should feel comfortable * Reviews are conversations and the PR author should feel comfortable
discussing and pushing back on changes before making them discussing and pushing back on changes before making them
* Reviewers are encouraged to ask for tests where they believe it is reasonable
* Core team should lead by example through their tone and language * Core team should lead by example through their tone and language
* Take the time to thank and point out good code changes * Take the time to thank and point out good code changes
* Using softer language like "please" and "what do you think?" goes a long way * Using softer language like "please" and "what do you think?" goes a long way