mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2026-05-04 19:56:45 +02:00
Code Issues Projects Releases Wiki Activity

Update stale screenshots playwright reporter

Browse Source 
At some point it seems that playwright changed how reporters are passed flakes.

https://github.com/microsoft/playwright/pull/39145 needs to land to fully fix the reporter though
This commit is contained in:
Michael Telatynski 2026-02-19 16:04:42 +00:00 committed by GitHub
parent 30cbbd48b3
commit a9e76dbb8a
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/element-web-playwright-common/src/stale-screenshot-reporter.ts
View File

@ -25,7 +25,7 @@ export const ANNOTATION = "_screenshot";
class StaleScreenshotReporter implements Reporter {
private readonly snapshotRoots = new Set<string>();
private readonly screenshots = new Set<string>();
private failing = false;
private readonly failing = new Set<string>();
private success = true;
public onBegin(config: FullConfig): void {
@ -36,8 +36,11 @@ class StaleScreenshotReporter implements Reporter {
public onTestEnd(test: TestCase): void {
if (!test.ok()) {
this.failing = true;
this.failing.add(test.id);
return;
}
this.failing.delete(test.id); // delete if passed on re-run
for (const annotation of test.annotations) {
if (annotation.type === ANNOTATION && annotation.description) {
this.screenshots.add(annotation.description);
@ -54,7 +57,10 @@ class StaleScreenshotReporter implements Reporter {
}
public async onExit(): Promise<void> {
if (this.failing) return;
if (this.failing.size) {
console.error(`${this.failing.size} tests failed, skipping stale screenshot reporter.`);
}
if (!this.snapshotRoots.size) {
this.error("No snapshot directories found, did you set the snapshotDir in your Playwright config?", "");
return;