mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2025-11-28 22:11:41 +01:00
Code Issues Projects Releases Wiki Activity

Prevent default form submission in MemberListView (#30312)

Browse Source
This commit is contained in:
AlirezaMrtz 2025-07-14 17:14:03 +03:30 committed by GitHub
parent 4bbcb8bb5d
commit 93f04f7aaa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/views/rooms/MemberList/MemberListView.tsx
View File

@ -95,7 +95,7 @@ const MemberListView: React.FC<IProps> = (props: IProps) => {
className="mx_MemberListView_container" className="mx_MemberListView_container"
onKeyDown={onKeyDownHandler} onKeyDown={onKeyDownHandler}
> >
<Form.Root> <Form.Root onSubmit={(e) => e.preventDefault()}>
<MemberListHeaderView vm={vm} /> <MemberListHeaderView vm={vm} />
</Form.Root> </Form.Root>
<AutoSizer> <AutoSizer>

12
test/unit-tests/components/views/rooms/memberlist/MemberListView-test.tsx
View File

@ -8,7 +8,7 @@ Please see LICENSE files in the repository root for full details.
*/ */
import { act } from "react"; import { act } from "react";
import { waitFor } from "jest-matrix-react"; import { waitFor, fireEvent } from "jest-matrix-react";
import { type Room, type RoomMember, MatrixEvent } from "matrix-js-sdk/src/matrix"; import { type Room, type RoomMember, MatrixEvent } from "matrix-js-sdk/src/matrix";
import { type JSX } from "react"; import { type JSX } from "react";
@ -154,6 +154,16 @@ describe("MemberListView and MemberlistHeaderView", () => {
expect(root.container.querySelector(".mx_PresenceIconView_unavailable")).not.toBeNull(); expect(root.container.querySelector(".mx_PresenceIconView_unavailable")).not.toBeNull();
}); });
}); });
it("should prevent default form submission", async () => {
const { root } = rendered;
const form = root.container.querySelector("form");
expect(form).not.toBeNull();
const submitEvent = new Event("submit", { bubbles: true, cancelable: true });
const preventDefaultSpy = jest.spyOn(submitEvent, "preventDefault");
fireEvent(form!, submitEvent);
expect(preventDefaultSpy).toHaveBeenCalled();
});
}); });
describe.each([true, false])("does order members correctly (presence %s)", (enablePresence) => { describe.each([true, false])("does order members correctly (presence %s)", (enablePresence) => {