From 9c09a1b7317b2609cc791d5b4a7a4f06f7a7b847 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 16 Apr 2026 16:25:52 +0100 Subject: [PATCH 1/2] Add `analytics` config to nx (#33175) * Add `analytics` config to nx There doesn't seem to be any way to stop nx wanting to add this config setting, so I think we just have to add it. * Update nx.json --- nx.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nx.json b/nx.json index 58b3b014cd..050a8c7d94 100644 --- a/nx.json +++ b/nx.json @@ -8,5 +8,6 @@ }, "namedInputs": { "src": ["{projectRoot}/src/**/*"] - } + }, + "analytics": false } From 733755abb2e7d189c094a8262b5e69d754619216 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 16 Apr 2026 16:26:04 +0100 Subject: [PATCH 2/2] Annotate output from playwright-screenshots scripts (#33176) ... to make it easier to see where it is coming from Also, add a blank line before starting playwright itself --- packages/playwright-common/playwright-screenshots.sh | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/playwright-common/playwright-screenshots.sh b/packages/playwright-common/playwright-screenshots.sh index ecf962f112..d860e34d12 100755 --- a/packages/playwright-common/playwright-screenshots.sh +++ b/packages/playwright-common/playwright-screenshots.sh @@ -9,7 +9,7 @@ SCRIPT_DIR=$(dirname "$SCRIPT_PATH") function build_image() { local IMAGE_NAME="$1" - echo "Building $IMAGE_NAME image in $SCRIPT_DIR" + echo "playwright-screenshots: Building $IMAGE_NAME image in $SCRIPT_DIR" docker build -t "$IMAGE_NAME" --build-arg "PLAYWRIGHT_VERSION=${IMAGE_NAME#*:}" "$SCRIPT_DIR" } @@ -34,16 +34,19 @@ CONTAINER=$(docker run --network=host -v /tmp:/tmp --rm -d -e PORT="$WS_PORT" "$ # Set up an exit trap to clean up the docker container clean_up() { ARG=$? - echo "Stopping playwright-server" + echo "playwright-screenshots: Stopping playwright-server" docker stop "$CONTAINER" > /dev/null exit $ARG } trap clean_up EXIT # Wait for playwright-server to be ready -echo "Waiting for playwright-server" +echo "playwright-screenshots: Waiting for playwright-server" pnpm --dir "$SCRIPT_DIR" exec wait-on "tcp:$WS_PORT" +# Playwright seems to overwrite the last line from the console, so add an +# extra newline to make sure this doesn't get lost. +echo -e "playwright-screenshots: Running '$@'\n" + # Run the test we were given, setting PW_TEST_CONNECT_WS_ENDPOINT accordingly -echo "Running '$@'" PW_TEST_CONNECT_WS_ENDPOINT="http://localhost:$WS_PORT" "$@"