mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2026-05-04 11:51:36 +02:00
Code Issues Projects Releases Wiki Activity

playwright-screenshots: clean up output and error handling

Browse Source 
Somebody wrote those `pushd` and `popd` lines without testing
them. Redirections bind tighter than `||` so those lines were always spamming
the console.

Using `set -e` is more reliable than always checking exit codes anyway.
This commit is contained in:
Richard van der Hoff 2025-11-04 23:47:09 +00:00
parent 6502ffcbe0
commit 28384f1112
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/element-web-playwright-common/playwright-screenshots.sh
View File

@ -1,5 +1,7 @@
#!/bin/bash
set -e
# Handle symlinks here as we tend to be executed as an npm binary
SCRIPT_PATH=$(readlink -f "$0")
SCRIPT_DIR=$(dirname "$SCRIPT_PATH")
@ -83,11 +85,11 @@ done
build_image
# Ensure we pass all symlinked node_modules to the container
pushd node_modules || exit > /dev/null
pushd node_modules > /dev/null
SYMLINKS=$(find . -maxdepth 2 -type l -not -path "./.bin/*")
popd || exit > /dev/null
popd > /dev/null
for LINK in $SYMLINKS; do
TARGET=$(readlink -f "node_modules/$LINK")
TARGET=$(readlink -f "node_modules/$LINK") || true
if [ -d "$TARGET" ]; then
echo "mounting linked package ${LINK:2} in container"
RUN_ARGS+=( "-v" "$TARGET:/work/node_modules/${LINK:2}" )