From 26779b10bd18ecc03d5509efa8c0c831db033d15 Mon Sep 17 00:00:00 2001 From: Florian Duros Date: Fri, 23 Jan 2026 12:17:22 +0100 Subject: [PATCH] fix: message preview toggle is inverted in room list header (#31865) --- src/viewmodels/room-list/RoomListHeaderViewModel.ts | 4 ++-- test/viewmodels/room-list/RoomListHeaderViewModel-test.ts | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/viewmodels/room-list/RoomListHeaderViewModel.ts b/src/viewmodels/room-list/RoomListHeaderViewModel.ts index 76e61504b5..fee0c954c3 100644 --- a/src/viewmodels/room-list/RoomListHeaderViewModel.ts +++ b/src/viewmodels/room-list/RoomListHeaderViewModel.ts @@ -189,8 +189,8 @@ export class RoomListHeaderViewModel public toggleMessagePreview = (): void => { PosthogTrackers.trackInteraction("WebRoomListMessagePreviewToggle"); - const isMessagePreviewEnabled = SettingsStore.getValue("RoomList.showMessagePreview"); - SettingsStore.setValue("RoomList.showMessagePreview", null, SettingLevel.DEVICE, !isMessagePreviewEnabled); + const isMessagePreviewEnabled = !SettingsStore.getValue("RoomList.showMessagePreview"); + SettingsStore.setValue("RoomList.showMessagePreview", null, SettingLevel.DEVICE, isMessagePreviewEnabled); this.snapshot.merge({ isMessagePreviewEnabled }); }; } diff --git a/test/viewmodels/room-list/RoomListHeaderViewModel-test.ts b/test/viewmodels/room-list/RoomListHeaderViewModel-test.ts index ca96762fa8..5c73e6c8ef 100644 --- a/test/viewmodels/room-list/RoomListHeaderViewModel-test.ts +++ b/test/viewmodels/room-list/RoomListHeaderViewModel-test.ts @@ -293,6 +293,7 @@ describe("RoomListHeaderViewModel", () => { vm.toggleMessagePreview(); expect(setValueSpy).toHaveBeenCalledWith("RoomList.showMessagePreview", null, expect.anything(), false); + expect(vm.getSnapshot().isMessagePreviewEnabled).toBe(false); }); }); });