mirrors/element-web
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2025-10-02 02:51:30 +02:00
Code Issues Projects Releases Wiki Activity

clarify event handlers

Browse Source
This commit is contained in:
David Baker 2016-07-08 15:58:18 +01:00
parent afa6acc20a
commit 1a3bc814e1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code_style.md
View File

@ -151,7 +151,7 @@ React
<Foo onClick={function(ev) {doStuff();}}> // Bad <Foo onClick={function(ev) {doStuff();}}> // Bad
<Foo onClick={(ev) => {doStuff();}}> // Equally bad <Foo onClick={(ev) => {doStuff();}}> // Equally bad
<Foo onClick={this.doStuff}> // Better <Foo onClick={this.doStuff}> // Better
<Foo onClick={this.onClick}> // Best <Foo onClick={this.onFooClick}> // Best, if onFooClick would do anything other than directly calling doStuff
``` ```
- Think about whether your component really needs state: are you duplicating - Think about whether your component really needs state: are you duplicating
information in component state that could be derived from the model? information in component state that could be derived from the model?