From 19cfddab6da7a6a180a3c724160ca450c58b2704 Mon Sep 17 00:00:00 2001 From: David Langley Date: Thu, 22 Jan 2026 19:20:36 +0000 Subject: [PATCH] Fix the logic and comments surrounding the e2e test: "should open the notification options menu" (#31853) * fix the logic and comments surrounding the e2e test * spacing * prettier --- .../e2e/left-panel/room-list-panel/room-list.spec.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts b/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts index ff1710091c..84dc161bea 100644 --- a/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts +++ b/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts @@ -121,23 +121,23 @@ test.describe("Room list", () => { // It should make the room muted await page.getByRole("menuitem", { name: "Mute room" }).click(); - await expect(roomItem.getByTestId("notification-decoration")).not.toBeVisible(); + // Not hovered, the room decoration should be the muted icon + await expect(roomItem.getByTestId("notification-decoration")).toBeVisible(); // Put focus on the room list await roomListView.getByRole("option", { name: "Open room room28" }).click(); - // Scroll to the end of the room list - await app.scrollListToBottom(roomListView); - - // The room decoration should have the muted icon + // During hover the room decoration should still be the muted icon await expect(roomItem.getByTestId("notification-decoration")).toBeVisible(); await roomItem.hover(); + // On hover, the room should show the muted icon await expect(roomItem).toMatchScreenshot("room-list-item-hover-silent.png"); roomItemMenu = roomItem.getByRole("button", { name: "Notification options" }); await roomItemMenu.click(); + // The Mute room option should be selected await expect(page.getByRole("menuitem", { name: "Mute room" })).toHaveAttribute("aria-selected", "true"); await expect(page).toMatchScreenshot("room-list-item-open-notification-options-selection.png");