mirror of
https://github.com/miekg/dns.git
synced 2025-08-10 03:26:57 +02:00
08c2616301
* Add SVCB dohpath key The parameter is being added in [its own IETF draft][1] and also being used in the [IETF draft about Descovery of Designated Resolvers][2]. Additionally, the mappings of the numeric key values to strings are exported, under names consistent with the already existing exported mappings, to make it easier for the clients of the module to validate and print SVCB keys. Testing was done by sending SVCB queries for the "_dns.resolver.arpa" domain to OpenDNS's 146.112.41.2 server. [1]: https://datatracker.ietf.org/doc/html/draft-ietf-add-svcb-dns-02 [2]: https://datatracker.ietf.org/doc/html/draft-ietf-add-ddr-06.html * Fix template length, docs; reverse some changes * Remove incorrect validations; improve docs
122 lines
2.5 KiB
Go
122 lines
2.5 KiB
Go
package dns
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
// This tests everything valid about SVCB but parsing.
|
|
// Parsing tests belong to parse_test.go.
|
|
func TestSVCB(t *testing.T) {
|
|
svcbs := []struct {
|
|
key string
|
|
data string
|
|
}{
|
|
{`mandatory`, `alpn,key65000`},
|
|
{`alpn`, `h2,h2c`},
|
|
{`port`, `499`},
|
|
{`ipv4hint`, `3.4.3.2,1.1.1.1`},
|
|
{`no-default-alpn`, ``},
|
|
{`ipv6hint`, `1::4:4:4:4,1::3:3:3:3`},
|
|
{`ech`, `YUdWc2JHOD0=`},
|
|
{`dohpath`, `/dns-query{?dns}`},
|
|
{`key65000`, `4\ 3`},
|
|
{`key65001`, `\"\ `},
|
|
{`key65002`, ``},
|
|
{`key65003`, `=\"\"`},
|
|
{`key65004`, `\254\ \ \030\000`},
|
|
}
|
|
|
|
for _, o := range svcbs {
|
|
keyCode := svcbStringToKey(o.key)
|
|
kv := makeSVCBKeyValue(keyCode)
|
|
if kv == nil {
|
|
t.Error("failed to parse svc key: ", o.key)
|
|
continue
|
|
}
|
|
if kv.Key() != keyCode {
|
|
t.Error("key constant is not in sync: ", keyCode)
|
|
continue
|
|
}
|
|
err := kv.parse(o.data)
|
|
if err != nil {
|
|
t.Error("failed to parse svc pair: ", o.key)
|
|
continue
|
|
}
|
|
b, err := kv.pack()
|
|
if err != nil {
|
|
t.Error("failed to pack value of svc pair: ", o.key, err)
|
|
continue
|
|
}
|
|
if len(b) != int(kv.len()) {
|
|
t.Errorf("expected packed svc value %s to be of length %d but got %d", o.key, int(kv.len()), len(b))
|
|
}
|
|
err = kv.unpack(b)
|
|
if err != nil {
|
|
t.Error("failed to unpack value of svc pair: ", o.key, err)
|
|
continue
|
|
}
|
|
if str := kv.String(); str != o.data {
|
|
t.Errorf("`%s' should be equal to\n`%s', but is `%s'", o.key, o.data, str)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDecodeBadSVCB(t *testing.T) {
|
|
svcbs := []struct {
|
|
key SVCBKey
|
|
data []byte
|
|
}{
|
|
{
|
|
key: SVCB_ALPN,
|
|
data: []byte{3, 0, 0}, // There aren't three octets after 3
|
|
},
|
|
{
|
|
key: SVCB_NO_DEFAULT_ALPN,
|
|
data: []byte{0},
|
|
},
|
|
{
|
|
key: SVCB_PORT,
|
|
data: []byte{},
|
|
},
|
|
{
|
|
key: SVCB_IPV4HINT,
|
|
data: []byte{0, 0, 0},
|
|
},
|
|
{
|
|
key: SVCB_IPV6HINT,
|
|
data: []byte{0, 0, 0},
|
|
},
|
|
}
|
|
for _, o := range svcbs {
|
|
err := makeSVCBKeyValue(SVCBKey(o.key)).unpack(o.data)
|
|
if err == nil {
|
|
t.Error("accepted invalid svc value with key ", SVCBKey(o.key).String())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCompareSVCB(t *testing.T) {
|
|
val1 := []SVCBKeyValue{
|
|
&SVCBPort{
|
|
Port: 117,
|
|
},
|
|
&SVCBAlpn{
|
|
Alpn: []string{"h2", "h3"},
|
|
},
|
|
}
|
|
val2 := []SVCBKeyValue{
|
|
&SVCBAlpn{
|
|
Alpn: []string{"h2", "h3"},
|
|
},
|
|
&SVCBPort{
|
|
Port: 117,
|
|
},
|
|
}
|
|
if !areSVCBPairArraysEqual(val1, val2) {
|
|
t.Error("svcb pairs were compared without sorting")
|
|
}
|
|
if val1[0].Key() != SVCB_PORT || val2[0].Key() != SVCB_ALPN {
|
|
t.Error("original svcb pairs were reordered during comparison")
|
|
}
|
|
}
|