mirrors/dns
1
0
Fork 0
mirror of https://github.com/miekg/dns.git synced 2025-08-18 23:41:00 +02:00
Code Issues Packages Projects Releases Wiki Activity
3,506 Commits 2 Branches 85 Tags
Commit Graph

461 Commits

Author SHA1 Message Date
Miek Gieben
d33af8db79 Update test and gofmt 2014-11-09 16:09:49 +00:00
Miek Gieben
eff0e9354f Apply 433ab7b5694fe9ac924eb29fe3fedfc3c05d9a84 here too 
The same Sprintf was used here, so this can be optimized as well.

Thanks to @andrewtj for the ping.
 2014-11-09 08:03:03 +00:00
Daniel Morsing
433ab7b569 Reduce amount of work done when unpacking unprintable characters. 
Instead of going through the fmt package, we can use append int,
which saves an allocation.

benchmark                                old ns/op     new ns/op     delta
BenchmarkUnpackDomainNameUnprintable     2147          506           -76.43%
 2014-11-06 13:51:29 +00:00
Andrew Tunnell-Jones
91b8c69a22 Implement SIG(0) signing and verification 
This is based on @miekg's sig0 branch. That branch diverged from master
and I didn't want to wander off on a rebase.

As implemented there's no allowance for multi-envelope (TCP) support.

TODO:

* unpackUint32() could be moved out and used elsewhere
* tests
* multi-envelope support (if useful)
 2014-11-01 11:32:46 +00:00
Miek Gieben
6bbae6c6ea Add CDNSKEY support 2014-10-23 22:18:23 +01:00
Miek Gieben
467e368cc1 check for overflowing msg len when unpacking A 
unclebadtouches catched this.

closes #141
 2014-10-22 21:08:34 +01:00
Miek Gieben
3d0face066 Fixup tests 2014-10-08 14:35:23 +00:00
Miek Gieben
de954625b6 Add ErrExtendedRcode and fix up the callers 2014-10-08 14:31:28 +00:00
Filippo Valsorda
9088298b2b Add support for extended RCODEs and detect bad RCODEs 2014-09-26 12:18:36 +01:00
Miek Gieben
9c455b0214 PrivateRR: naming naming naming 
Try to find better (=more in sync with the rest of the lib) naming. My
guess is that these are better, but YMMV.
 2014-09-21 08:28:38 +01:00
Alex Sergeyev
fcf9302ae1 Changed logic to typeswitch and added comments. 
And also added my name to contrib list as promised before.
 2014-09-20 18:15:42 -04:00
Alex Sergeyev
8aab8c6fb2 Lots of renamed funcs and structures. More readability. 2014-09-20 18:07:36 -04:00
Alex Sergeyev
5b8552609c Added docstrings, tests and example for PrivateRRs. 
(renamed CustomRR to PrivateRR)
 2014-09-19 17:30:10 -04:00
Alex Sergeyev
7c507e7592 New functionality for adding private RRs to dns lib. 2014-09-19 17:28:53 -04:00
Miek Gieben
02dd474056 Dont export typeToRR (old rr_mk) 2014-09-16 07:31:20 +01:00
Miek Gieben
bcb640ccaf Make rr_mk public and call it TypeToRR 2014-09-16 07:15:06 +01:00
Miek Gieben
0aa3021a83 Remove all copyright notices 
Use the central COPYRIGHT file.
 2014-09-11 20:57:37 +01:00
Miek Gieben
8fecf17714 Check that off <= lenmsg 
Defense in depth, this should happen, but it happens... So check
for it and return an error.

Maybe (there is no testcase) fixes #106
 2014-08-23 07:43:00 +01:00
Miek Gieben
34f5a12bfc Don't crash on emtpy string in compressionLenSearch 
Fixes #105
 2014-08-22 08:46:24 +00:00
Miek Gieben
4d3dac9c36 Add the OPENPGPKEY RR. 2014-08-14 09:18:08 +01:00
Miek Gieben
4dd48338af documentation tweaks 2014-07-30 07:35:06 +01:00
Miek Gieben
1243dcbc89 Make Id a variable to points to id (renamed from Id()) 
This way the Id function can be overruled by clients to have
another implementation for the Id function:

To make it static: dns.Id = func() uint16 { return 1234 }
 2014-07-30 07:17:13 +01:00
Miek Gieben
060e66250e Add IsMsg() 
A quick validating function that checks if a buffer is a valid
DNS message.
The code is *far* from complete.
 2014-05-18 09:02:00 +01:00
Andrew Tunnell-Jones
8772f9064c Make PackRR enforce RR data length limit 
• Make rawSetRdlength return false if length would overflow
• Make PackRR assume rawSetRdlength returning false indicates an overflow
 2014-04-29 05:03:01 +00:00
Miek Gieben
b7a8c14d7d Add dns.Name as a type 
This can be used for printing names.
 2014-04-23 21:06:17 +01:00
Miek Gieben
fcbb2e7a9a Check and better errors 2014-04-08 00:09:26 +01:00
Miek Gieben
abe6de223d Add some more checks 2014-04-05 08:06:49 +01:00
Miek Gieben
a211645d0a Also check for msg length 2014-04-04 19:43:39 +01:00
Miek Gieben
541776149c Merge pull request #85 from andrewtj/atj-encoding 
Parsing and Stringer Changes
 2014-03-02 16:48:46 +00:00
Andrew Tunnell-Jones
38d78bafe4 Escape @ when printing/unpacking domain names 2014-03-01 22:30:52 +00:00
Andrew Tunnell-Jones
3ba746b6ca Convention is Txt not TXT in msg.go function names 2014-03-01 22:25:24 +00:00
Marek Majkowski
999a3ce301 Reduce number of memory allocations in msg.Copy 
Right now we allocate memory even for empty slices. This is inefficient, sticking "nil" as a slice is good enough if there are no items.
 2014-02-28 07:03:21 -08:00
Andrew Tunnell-Jones
3f834a04fb Update domain name and TXT string escape behaviour 
Changes to domain name packing and unpacking:
* Escape dot, backslash, brackets, double-quote, semi-colon and space
* Tab, line feed and carriage return become \t, \n and \r

Changes to TXT string packing and unpacking:
* Escape backslash and double-quote
* Tab, line feed and carriage return become \t, \n and \r
* Other unprintables to \DDD

Stringers do the equivalent of putting domain names and TXT strings
to the wire and back.

There is some duplication of logic. I found performance suffered when
I broke the logic out into smaller functions. I think this may have
been due to functions not being inlined for various reasons.
 2014-02-26 10:55:11 +00:00
Andrew Tunnell-Jones
c500de0e7a Fix HIP record unpacking 
* limit decoding of Hit to HitLength
* limit decoding of PublicKey to PublicKeyLength
* limit decoding of RendezvousServers to rdata's length
 2014-02-22 05:28:48 +00:00
Andrew Tunnell-Jones
4bf3023c78 Handle label ending in an escaped dot in PackDomain 2014-02-15 00:40:53 +00:00
Miek Gieben
87b380cad5 Revert "Use dLen for domain name length" 
This reverts commit b59518383446378cde7758d16f925b5ee324c5a4.

Fix up the tests too.
 2014-02-14 20:20:22 +00:00
Miek Gieben
89cc033428 Be much more precice in msg.Len() 
There is still a one-off in EDNS0 records, but I'm not too bothered with
that one.
 2014-02-12 12:59:42 +00:00
Miek Gieben
31102c38b7 Make Len() much more accurate for compressed messages. 
Lots of changes made and bugs fixed.
 2014-02-11 23:01:47 +00:00
Miek Gieben
8f334b52a0 Merge branch 'master' of github.com:miekg/dns 2014-02-10 15:31:20 +00:00
Miek Gieben
6293844a72 Check compression lengths 2014-02-10 12:43:38 +00:00
Miek Gieben
0cba5240c3 More tests lenght 2014-02-10 12:43:09 +00:00
Miek Gieben
56e0bb46d8 Remove packLen() and fix bug in Len() 
packLen() was a featureless mirror of Len(). Remove it, and just use
Len() internally too.
Fix bug in Len() too, where the length of the additional section was
not counted.
 2014-02-10 12:23:53 +00:00
Miek Gieben
5ecc38c003 Better docs 2014-02-06 10:32:38 +00:00
Miek Gieben
4f6fef6777 If the TC bit is set return a valid but smaller message 
If the TC bit is set in a message, we will probably try to parse
half a message, which will fail. To fix this just return a message
header and the question section and don't parse the rest.
 2014-02-05 21:47:26 +00:00
Miek Gieben
95fd782f44 Fix documentation for these public functions 2014-02-05 21:38:12 +00:00
Alex Ciuba
16d6ebe1c1 Use slice to build domain string 2014-02-01 01:29:00 -05:00
Miek Gieben
9ba617e870 Revert "Share the message buffer if we have room" 
This reverts commit 17ce0cd52fbd64f62638ae0bdb7c3a6a07d4d0be.
 2014-01-28 22:43:48 +00:00
Miek Gieben
27abc83e6a Merge pull request #80 from millerkil/optimize 
A couple optimizations
 2014-01-27 23:58:06 -08:00
Alex Ciuba
17ce0cd52f Share the message buffer if we have room 2014-01-27 19:45:45 -05:00
Miek Gieben
9c0ff1489b Merge branch 'master' of github.com:miekg/dns 2014-01-27 14:32:07 +00:00