* Add a hook to catch invalid messages
Currently there are hooks for reading messages off the wire (DecorateReader),
checking if they comply with policy (MsgAcceptFunc), and generating responses
(Handler). However, there is no hook that notifies the server when a message is
dropped or rejected due to a syntax error. That makes it hard to monitor these
packets without repeating the parsing process.
This PR adds a hook for notifications about invalid packets.
* s/InvalidMsg/MsgInvalid/g
* Support generic net.PacketConn's for the Server
This commit adds support for listening on generic net.PacketConn's for
UDP DNS requests, previously *net.UDPConn was the only supported type.
In the event of a future v2 of this module, this should be streamlined.
* Eliminate wrapper functions around RunLocalXServerWithFinChan
* Eliminate RunLocalTCPServerWithTsig function
* Replace RunLocalTLSServer with a wrapper around RunLocalTCPServer
This reduces code duplication.
* Add net.PacketConn server tests
This provides coverage over nearly all of the newly added code (with
the unfortunate exception of (*response).RemoteAddr).
* Fix broken client_test.go tests
a433fbede4dc was merged into master between this PR being opened and
being merged. This broke the CI tests in rather strange ways as the
code was being merged into master in a way that wasn't at all clear.
This commit fixes the two broken lines.
* RFC 1996 allows SOA in answer in notify
The answer section of a notify can contain a SOA record that we should
not ignore in the DefaultAcceptFunc.
* End sentence
Signed-off-by: Miek Gieben <miek@miek.nl>
