mirrors/dns
1
0
Fork 0
mirror of https://github.com/miekg/dns.git synced 2025-10-11 09:51:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix overflow when the buffer is really small

Browse Source
This commit is contained in:
Miek Gieben 2012-01-29 19:11:55 +01:00
parent 402ce277df
commit b639fa305d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
msg.go
View File

@ -806,8 +806,12 @@ func unpackStructValue(val reflect.Value, msg []byte, off int) (off1 int, ok boo
// Work because of rfc4034, section 3.17 // Work because of rfc4034, section 3.17
consumed += len(val.FieldByName("SignerName").String()) + 1 consumed += len(val.FieldByName("SignerName").String()) + 1
default: default:
consumed = 0 // TODO consumed = 0 // TODO, maybe error?
} }
if off+rdlength-consumed > lenmsg {
println("dns: failure unpacking base64")
return lenmsg, false
}
s = unpackBase64(msg[off : off+rdlength-consumed]) s = unpackBase64(msg[off : off+rdlength-consumed])
off += rdlength - consumed off += rdlength - consumed
case "cdomain-name": case "cdomain-name":