mirrors/coturn
1
0
Fork 0
mirror of https://github.com/coturn/coturn.git synced 2025-10-25 13:00:59 +02:00
Code Issues Projects Releases Wiki Activity

Fix memory leak in rfc5769check.c (#1410)

Browse Source 
I came across the open issue #1368 which is a leaksanitizer report about
a leak that happens on make check. I was able to reproduce the bug on
running `make check` and was able to generate a patch for it. The leak
happens within function `check_oauth`.

Issue: The variable `base64encoded_ltp` is allocated within
`base64_encode` however it is not de-allocated within the coming loop.

I have verified that after the patch, the leak no longer occurs through
`leaksanitizer` (and there is no double free for that matter)

---------

Co-authored-by: Pavel Punsky <eakraly@users.noreply.github.com>
This commit is contained in:
ashamedbit 2024-03-03 17:04:40 -05:00 committed by GitHub
parent 456e2e81b3
commit 412788b120
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/apps/rfc5769/rfc5769check.c
View File

@ -132,7 +132,7 @@ static int check_oauth(void) {
if (convert_oauth_key_data(&okd, &key, err_msg, err_msg_size) < 0) { if (convert_oauth_key_data(&okd, &key, err_msg, err_msg_size) < 0) {
fprintf(stderr, "%s\n", err_msg); fprintf(stderr, "%s\n", err_msg);
return -1; goto ERROR;
} }
} }
} }
@ -148,7 +148,7 @@ static int check_oauth(void) {
if (encode_oauth_token((const uint8_t *)server_name, &etoken, &key, &ot, (const uint8_t *)gcm_nonce) < 0) { if (encode_oauth_token((const uint8_t *)server_name, &etoken, &key, &ot, (const uint8_t *)gcm_nonce) < 0) {
fprintf(stderr, "%s: cannot encode oauth token\n", __FUNCTION__); fprintf(stderr, "%s: cannot encode oauth token\n", __FUNCTION__);
return -1; goto ERROR;
} }
if (print_extra) { if (print_extra) {
@ -157,30 +157,30 @@ static int check_oauth(void) {
if (decode_oauth_token((const uint8_t *)server_name, &etoken, &key, &dot) < 0) { if (decode_oauth_token((const uint8_t *)server_name, &etoken, &key, &dot) < 0) {
fprintf(stderr, "%s: cannot decode oauth token\n", __FUNCTION__); fprintf(stderr, "%s: cannot decode oauth token\n", __FUNCTION__);
return -1; goto ERROR;
} }
} }
if (strcmp((char *)ot.enc_block.mac_key, (char *)dot.enc_block.mac_key)) { if (strcmp((char *)ot.enc_block.mac_key, (char *)dot.enc_block.mac_key)) {
fprintf(stderr, "%s: wrong mac key: %s, must be %s\n", __FUNCTION__, (char *)dot.enc_block.mac_key, fprintf(stderr, "%s: wrong mac key: %s, must be %s\n", __FUNCTION__, (char *)dot.enc_block.mac_key,
(char *)ot.enc_block.mac_key); (char *)ot.enc_block.mac_key);
return -1; goto ERROR;
} }
if (ot.enc_block.key_length != dot.enc_block.key_length) { if (ot.enc_block.key_length != dot.enc_block.key_length) {
fprintf(stderr, "%s: wrong key length: %d, must be %d\n", __FUNCTION__, (int)dot.enc_block.key_length, fprintf(stderr, "%s: wrong key length: %d, must be %d\n", __FUNCTION__, (int)dot.enc_block.key_length,
(int)ot.enc_block.key_length); (int)ot.enc_block.key_length);
return -1; goto ERROR;
} }
if (ot.enc_block.timestamp != dot.enc_block.timestamp) { if (ot.enc_block.timestamp != dot.enc_block.timestamp) {
fprintf(stderr, "%s: wrong timestamp: %llu, must be %llu\n", __FUNCTION__, fprintf(stderr, "%s: wrong timestamp: %llu, must be %llu\n", __FUNCTION__,
(unsigned long long)dot.enc_block.timestamp, (unsigned long long)ot.enc_block.timestamp); (unsigned long long)dot.enc_block.timestamp, (unsigned long long)ot.enc_block.timestamp);
return -1; goto ERROR;
} }
if (ot.enc_block.lifetime != dot.enc_block.lifetime) { if (ot.enc_block.lifetime != dot.enc_block.lifetime) {
fprintf(stderr, "%s: wrong lifetime: %lu, must be %lu\n", __FUNCTION__, (unsigned long)dot.enc_block.lifetime, fprintf(stderr, "%s: wrong lifetime: %lu, must be %lu\n", __FUNCTION__, (unsigned long)dot.enc_block.lifetime,
(unsigned long)ot.enc_block.lifetime); (unsigned long)ot.enc_block.lifetime);
return -1; goto ERROR;
} }
printf("OK\n"); printf("OK\n");
@ -188,7 +188,16 @@ static int check_oauth(void) {
} }
} }
if (base64encoded_ltp) {
free(base64encoded_ltp);
}
return 0; return 0;
ERROR:
if (base64encoded_ltp) {
free(base64encoded_ltp);
}
return -1;
} }
////////////////////////////////////////////////// //////////////////////////////////////////////////