mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-26 05:41:00 +01:00 
			
		
		
		
	This reloader didn't close the openened file handle. Add a close. Can't use `defer` because this is in a endless loop. Signed-off-by: Miek Gieben <miek@miek.nl>
		
			
				
	
	
		
			63 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			63 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package file
 | |
| 
 | |
| import (
 | |
| 	"os"
 | |
| 	"time"
 | |
| )
 | |
| 
 | |
| // Reload reloads a zone when it is changed on disk. If z.NoReload is true, no reloading will be done.
 | |
| func (z *Zone) Reload() error {
 | |
| 	if z.ReloadInterval == 0 {
 | |
| 		return nil
 | |
| 	}
 | |
| 	tick := time.NewTicker(z.ReloadInterval)
 | |
| 
 | |
| 	go func() {
 | |
| 		for {
 | |
| 			select {
 | |
| 			case <-tick.C:
 | |
| 				zFile := z.File()
 | |
| 				reader, err := os.Open(zFile)
 | |
| 				if err != nil {
 | |
| 					log.Errorf("Failed to open zone %q in %q: %v", z.origin, zFile, err)
 | |
| 					continue
 | |
| 				}
 | |
| 
 | |
| 				serial := z.SOASerialIfDefined()
 | |
| 				zone, err := Parse(reader, z.origin, zFile, serial)
 | |
| 				reader.Close()
 | |
| 				if err != nil {
 | |
| 					if _, ok := err.(*serialErr); !ok {
 | |
| 						log.Errorf("Parsing zone %q: %v", z.origin, err)
 | |
| 					}
 | |
| 					continue
 | |
| 				}
 | |
| 
 | |
| 				// copy elements we need
 | |
| 				z.Lock()
 | |
| 				z.Apex = zone.Apex
 | |
| 				z.Tree = zone.Tree
 | |
| 				z.Unlock()
 | |
| 
 | |
| 				log.Infof("Successfully reloaded zone %q in %q with %d SOA serial", z.origin, zFile, z.Apex.SOA.Serial)
 | |
| 				z.Notify()
 | |
| 
 | |
| 			case <-z.reloadShutdown:
 | |
| 				tick.Stop()
 | |
| 				return
 | |
| 			}
 | |
| 		}
 | |
| 	}()
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // SOASerialIfDefined returns the SOA's serial if the zone has a SOA record in the Apex, or -1 otherwise.
 | |
| func (z *Zone) SOASerialIfDefined() int64 {
 | |
| 	z.RLock()
 | |
| 	defer z.RUnlock()
 | |
| 	if z.Apex.SOA != nil {
 | |
| 		return int64(z.Apex.SOA.Serial)
 | |
| 	}
 | |
| 	return -1
 | |
| }
 |