mirror of
https://github.com/coredns/coredns.git
synced 2025-10-26 05:41:00 +01:00
01e13c622e
After calling NewZone the number of records should be zero, but due to how zone.All() was implemented so empty RRs would be added. This then fails the == 0 check in xfr.go and put nil in the slice, this then subsequently panics on the Len(). Fix this making All() smarter when adding records. Added little test to enfore this. Signed-off-by: Miek Gieben <miek@miek.nl>
44 lines
1.5 KiB
Go
44 lines
1.5 KiB
Go
package file
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func ExampleZone_All() {
|
|
zone, err := Parse(strings.NewReader(dbMiekNL), testzone, "stdin", 0)
|
|
if err != nil {
|
|
return
|
|
}
|
|
records := zone.All()
|
|
for _, r := range records {
|
|
fmt.Printf("%+v\n", r)
|
|
}
|
|
// Output
|
|
// xfr_test.go:15: miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1282630057 14400 3600 604800 14400
|
|
// xfr_test.go:15: www.miek.nl. 1800 IN CNAME a.miek.nl.
|
|
// xfr_test.go:15: miek.nl. 1800 IN NS linode.atoom.net.
|
|
// xfr_test.go:15: miek.nl. 1800 IN NS ns-ext.nlnetlabs.nl.
|
|
// xfr_test.go:15: miek.nl. 1800 IN NS omval.tednet.nl.
|
|
// xfr_test.go:15: miek.nl. 1800 IN NS ext.ns.whyscream.net.
|
|
// xfr_test.go:15: miek.nl. 1800 IN MX 1 aspmx.l.google.com.
|
|
// xfr_test.go:15: miek.nl. 1800 IN MX 5 alt1.aspmx.l.google.com.
|
|
// xfr_test.go:15: miek.nl. 1800 IN MX 5 alt2.aspmx.l.google.com.
|
|
// xfr_test.go:15: miek.nl. 1800 IN MX 10 aspmx2.googlemail.com.
|
|
// xfr_test.go:15: miek.nl. 1800 IN MX 10 aspmx3.googlemail.com.
|
|
// xfr_test.go:15: miek.nl. 1800 IN A 139.162.196.78
|
|
// xfr_test.go:15: miek.nl. 1800 IN AAAA 2a01:7e00::f03c:91ff:fef1:6735
|
|
// xfr_test.go:15: archive.miek.nl. 1800 IN CNAME a.miek.nl.
|
|
// xfr_test.go:15: a.miek.nl. 1800 IN A 139.162.196.78
|
|
// xfr_test.go:15: a.miek.nl. 1800 IN AAAA 2a01:7e00::f03c:91ff:fef1:6735
|
|
}
|
|
|
|
func TestAllNewZone(t *testing.T) {
|
|
zone := NewZone("example.org.", "stdin")
|
|
records := zone.All()
|
|
if len(records) != 0 {
|
|
t.Errorf("Expected %d records in empty zone, got %d", 0, len(records))
|
|
}
|
|
}
|