mirror of
https://github.com/coredns/coredns.git
synced 2025-08-06 22:37:03 +02:00
1948b6efc3
Add conditional test skipping for bind and readme tests that rely on Linux-specific loopback interface behavior. These tests reference network configurations that may not exist on for e.g. macOS or other platforms, causing spurious test failures. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
55 lines
1.6 KiB
Go
55 lines
1.6 KiB
Go
package bind
|
|
|
|
import (
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/coredns/caddy"
|
|
"github.com/coredns/coredns/core/dnsserver"
|
|
)
|
|
|
|
func TestSetup(t *testing.T) {
|
|
// Skip on non-Linux systems as some tests refer to for e.g. loopback interfaces which
|
|
// are not present on all systems.
|
|
if runtime.GOOS != "linux" {
|
|
t.Skipf("Skipping bind test on %s", runtime.GOOS)
|
|
}
|
|
|
|
for i, test := range []struct {
|
|
config string
|
|
expected []string
|
|
failing bool
|
|
}{
|
|
{`bind 1.2.3.4`, []string{"1.2.3.4"}, false},
|
|
{`bind`, nil, true},
|
|
{`bind 1.2.3.invalid`, nil, true},
|
|
{`bind 1.2.3.4 ::5`, []string{"1.2.3.4", "::5"}, false},
|
|
{`bind ::1 1.2.3.4 ::5 127.9.9.0`, []string{"::1", "1.2.3.4", "::5", "127.9.9.0"}, false},
|
|
{`bind ::1 1.2.3.4 ::5 127.9.9.0 noone`, nil, true},
|
|
{`bind 1.2.3.4 lo`, []string{"1.2.3.4", "127.0.0.1", "::1"}, false},
|
|
{"bind lo {\nexcept 127.0.0.1\n}\n", []string{"::1"}, false},
|
|
} {
|
|
c := caddy.NewTestController("dns", test.config)
|
|
err := setup(c)
|
|
if err != nil {
|
|
if !test.failing {
|
|
t.Fatalf("Test %d, expected no errors, but got: %v", i, err)
|
|
}
|
|
continue
|
|
}
|
|
if test.failing {
|
|
t.Fatalf("Test %d, expected to failed but did not, returned values", i)
|
|
}
|
|
cfg := dnsserver.GetConfig(c)
|
|
if len(cfg.ListenHosts) != len(test.expected) {
|
|
t.Errorf("Test %d : expected the config's ListenHosts size to be %d, was %d", i, len(test.expected), len(cfg.ListenHosts))
|
|
continue
|
|
}
|
|
for i, v := range test.expected {
|
|
if got, want := cfg.ListenHosts[i], v; got != want {
|
|
t.Errorf("Test %d : expected the config's ListenHost to be %s, was %s", i, want, got)
|
|
}
|
|
}
|
|
}
|
|
}
|