3 Commits

Author	SHA1	Message	Date
Miek Gieben	118b0c9408	plugin/metrcs: fix datarace on listeners (#2835) ... This fixes a data race on the listener(s) that get started in the metrics plugins. It also restore pkg/uniq to its former glory and removes and state being carried in there; this means for metrics that registry.go was to replicate that behavior *with* locking (as pkg/uniq doesn't do, or need that). Also renamed uniqAddr to just u, to make it slightly shorter. Signed-off-by: Miek Gieben <miek@miek.nl>	2019-05-18 18:34:46 +01:00
Francois Tur	05204ef142	Metrics registered on wrong prometheus registry (#2246) ... * - UT on metrics verifying that all plugins of all blocs have their metrics collectors declared * - fix error msg * - redirect Registry of metric to the one that handle the listener - allow duplicate of metrics collector on the same Registry (case of same plugin in 2 blocs listening metrics on the same address) * - fix change of signature * - ensure cleaning metrics before starting the test (metrics collectors are global vars .. and re-used by several tests) * - I think I fixed this test. Ensure correct mn of hits and clean metrics before test. * - fix typo in error msg - proposed at review * - fix typo in comment * - remove ResetMetrics functions - change a way to test the numeric metrics : get the diff between begin and end of test * - oops. removing debug logs	2018-11-01 19:56:00 +00:00
Miek Gieben	5e6114b797	plugin/pkg/uniq: add (#1733) ... Spin this out the metrics package so we can use it in the health one of well to fix some reload bugs.	2018-04-25 11:45:09 +01:00