mirror of
https://github.com/coredhcp/coredhcp.git
synced 2026-05-05 12:06:13 +02:00
3806733ad7
This removes the `interface` configuration statement and makes coredhcp accept a wider range of specifications in the `listen` configuration statement, notably: * Omitting the statement entirely yields the default behaviour: listening on `[::]:547`(and joining `ff02::1:2` and `ff05::1:3`) or `0.0.0.0:67` * Omitting the `:port` is accepted and means the default port for the protocol version. Conversely specifying `:port` means `[::]:port` or `0.0.0.0:port` * `ip%iface` and `ip%iface:port` are accepted, and result in binding to the specified interface. This is the general replacement for the interface statement * `%iface` and `%iface:port` are also accepted and mean the wildcard address, for a direct replacement of having interface specified but listen empty Signed-off-by: Anatole Denis <anatole@unverle.fr>
53 lines
2.3 KiB
Go
53 lines
2.3 KiB
Go
// Copyright 2018-present the CoreDHCP Authors. All rights reserved
|
|
// This source code is licensed under the MIT license found in the
|
|
// LICENSE file in the root directory of this source tree.
|
|
|
|
package config
|
|
|
|
import "testing"
|
|
|
|
func TestSplitHostPort(t *testing.T) {
|
|
testcases := []struct {
|
|
hostport string
|
|
ip string
|
|
zone string
|
|
port string
|
|
err bool // Should return an error (ie true for err != nil)
|
|
}{
|
|
{"0.0.0.0:67", "0.0.0.0", "", "67", false},
|
|
{"192.0.2.0", "192.0.2.0", "", "", false},
|
|
{"192.0.2.9%eth0", "192.0.2.9", "eth0", "", false},
|
|
{"0.0.0.0%eth0:67", "0.0.0.0", "eth0", "67", false},
|
|
{"0.0.0.0:20%eth0:67", "0.0.0.0", "eth0", "67", true},
|
|
{"2001:db8::1:547", "", "", "547", true}, // [] mandatory for v6
|
|
{"[::]:547", "::", "", "547", false},
|
|
{"[fe80::1%eth0]", "fe80::1", "eth0", "", false},
|
|
{"[fe80::1]:eth1", "fe80::1", "", "eth1", false}, // no validation of ports in this function
|
|
{"fe80::1%eth0:547", "fe80::1", "eth0", "547", true}, // [] mandatory for v6 even with %zone
|
|
{"fe80::1%eth0", "fe80::1", "eth0", "547", true}, // [] mandatory for v6 even without port
|
|
{"[2001:db8::2]47", "fe80::1", "eth0", "547", true}, // garbage after []
|
|
{"[ff02::1:2]%srv_u:547", "ff02::1:2", "srv_u", "547", true}, // FIXME: Linux `ss` format, we should accept but net.SplitHostPort doesn't
|
|
{":http", "", "", "http", false},
|
|
{"%eth0:80", "", "eth0", "80", false}, // janky, but looks valid enough for "[::%eth0]:80" imo
|
|
{"%eth0", "", "eth0", "", false}, // janky
|
|
{"fe80::1]:80", "fe80::1", "", "80", true}, // unbalanced ]
|
|
{"fe80::1%eth0]", "fe80::1", "eth0", "", true}, // unbalanced ], no port
|
|
{"", "", "", "", false}, // trivial case, still valid
|
|
}
|
|
|
|
for _, tc := range testcases {
|
|
ip, zone, port, err := splitHostPort(tc.hostport)
|
|
if tc.err != (err != nil) {
|
|
errState := "not "
|
|
if tc.err {
|
|
errState = ""
|
|
}
|
|
t.Errorf("Mismatched error state: %s should %serror (got err: %v)\n", tc.hostport, errState, err)
|
|
continue
|
|
}
|
|
if err == nil && (ip != tc.ip || zone != tc.zone || port != tc.port) {
|
|
t.Errorf("%s => \"%s\", \"%s\", \"%s\" expected \"%s\",\"%s\",\"%s\"\n", tc.hostport, ip, zone, port, tc.ip, tc.zone, tc.port)
|
|
}
|
|
}
|
|
}
|