armbian_build/patch/kernel/archive/sunxi-5.4/fix-a64-timejump.patch
Uglymotha 314061c3c3
Improve sunxi fix-a64-timejump.patch (#2824)
* Improve sunxi fix-a64-timejump.patch

Current patch still throws BUG:
WARNING: CPU: 2 PID: 31 at drivers/clocksource/arm_arch_timer.c:364 sun50i_a64_read_cntpct_el0+0x2c/0x38

Cause: Timer values are required to be exactly the same, while it may increase in between reads. Seems to happen especially during boot
Timer values are like: x2 : 0000000015014561 - x0 : 0000000015014567

Solution: Normalize timer values and return normalized value.

* Add patch for 5.12.y

Note. Small changes on upstream solution:
GENMASK(9, 0 ... -> GENMASK(8, 0 ...

Co-authored-by: Igor Pecovnik <igor.pecovnik@gmail.com>
2021-05-23 00:06:52 +02:00

37 lines
2.0 KiB
Diff

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 9a5464c62..91142959c 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -341,17 +341,20 @@ static u64 notrace arm64_858921_read_cntvct_el0(void)
* with all ones or all zeros in the low bits. Bound the loop by the maximum
* number of CPU cycles in 3 consecutive 24 MHz counter periods.
*/
-#define __sun50i_a64_read_reg(reg) ({ \
- u64 _val; \
- int _retries = 150; \
- \
- do { \
- _val = read_sysreg(reg); \
- _retries--; \
- } while (((_val + 1) & GENMASK(9, 0)) <= 1 && _retries); \
- \
- WARN_ON_ONCE(!_retries); \
- _val; \
+#define __sun50i_a64_read_reg(reg) ({ \
+ register u64 _tries = 5, _old, _new; \
+ \
+ do { \
+ if (unlikely(_tries < 3)) \
+ isb(); \
+ _old = read_sysreg(reg); \
+ _new = read_sysreg(reg); \
+ } while (unlikely((_new - _old) >> 4) && --_tries); \
+ \
+ if (unlikely(!_tries)) \
+ pr_err("(cpu %d) returning possibly incorrect counter value %llx (%llx)\n", \
+ smp_processor_id() + 1, _new, _old); \
+ _new; \
})
static u64 notrace sun50i_a64_read_cntpct_el0(void)