mirror of
https://github.com/armbian/build.git
synced 2025-09-11 00:31:12 +02:00
> tl-dr: > - maximize OCI cache hit ratio across nightlies/releases/PRs/etc; > - publish simple `Version:`'s that don't include a crazy hash in repo and images > - introduce `output/packages-hashed` directory > - radically change the `output/debs` directory structure - simplify artifact's `prepare_version()` method for `deb` and `deb-tar` artifacts: - `artifact_base_dir` and `artifact_final_file` will now be auto-calculated; thus removed from each artifact (except `rootfs`) - `artifact_deb_repo` ("global", "jammy", "bookworm") is now required; "global" means common across all RELEASES - `artifact_deb_arch` is now required, "all" is arch-independent, otherwise use `${ARCH}` - `artifact_map_debs` is now auto-calculated based on the above, and shouldn't be specified manually - `artifact_final_version_reversioned` is optional, and can force the final version of the artifact (specific for the `base-files` case) - artifacts that need special handling for reversioning can add function names to `artifact_debs_reversion_functions` array (`base-files` and `bsp-cli` cases) - artifacts `prepare_version()` should set `artifact_version`, but _never_ include it in other variables; `artifact_version` is now changed by framework after `prepare_version()` returns - no longer use/refer/mention `${REVISION}` when building packages. All packages should be `${REVISION}`-agnostic. - `${REVISION}` (actually, `artifact_final_version_reversioned`) will be automatically swapped in the `control` file during reversioning - `fakeroot_dpkg_deb_build()` now takes exactly two arguments: the directory to pack, and the deb ID (key of `artifact_map_packages` dict); add this change in all the artifact's code for this - `obtain_complete_artifact()`: - automatically adds `-Rxxxx` "revisioning-hash" to `artifact_version`, by hashing the revisioning functions and any `artifact_debs_reversion_functions` set - calculates more complex subdirectory paths for both the `output/packages-hashed` and `output/debs`/`output/debs-beta` directories - with the new subdirectories we can be sure a re-version is already done correctly and can skip it (eg, for partial `download-debs` re-runs) - in the future we can automatically clean/remove old versions that are no longer relevant based on the dir structure - exports a lot more information to JSON, including the new subdirectory paths - comment-out code that implemented `skip_unpack_if_found_in_caches`, I'm very unsure why we had this in the first place - `obtain_artifact_from_remote_cache()` - for `deb` type artifacts, OCI won't preserve the subdirectory structure, so move downloaded files to the correct subdirectory manually - this is not needed for `deb-tar`, since that can preserve the dir structure itself - introduce `artifacts-reversion.sh` and its main function `artifact_reversion_for_deployment()` - this has the logic for reversioning .deb's, by `ar`-unpacking them, changing `control.tar` (and possibly `data.tar`), handling `.xz` compression, etc. - also handles hashing those functions, for consistency. Any changes in reversioning code actually change the artifact itself so we're not caught by surprise - by default, it changes `control` file only: - replace `Version:` (which is the hash-version originally) with `artifact_final_version_reversioned` (which is mostly just `${REVISION}`) - add a custom field `Armbian-Original-Hash:` with the original hash-version - `artifact_reversion_for_deployment()` is called by - new CLI wrapper `cli_obtain_complete_artifact()`, used for CLI building of specific artifact, but also for `download-artifact` - `build_artifact_for_image()` used during image build - `armbian-bsp-cli-deb.sh`: move `${REVISION}` related stuff from the main package build to new reversioning functions. - `artifact-armbian-base-files.sh`: move `${REVISION}` related stuff from the main package build to new reversioning functions. - `kernel`: - add some custom fields to `DEBIAN/control`: - `Armbian-Kernel-Version:` / `Armbian-Kernel-Version-Family:` (for future use: cleanup of usage of `Source: ` field which should be removed) - declutter the `Description:` field, moving long description out of the first line - obtain `IMAGE_INSTALLED_KERNEL_VERSION` from the reversioned deb (this is still a hack and has not been fixed) - `uboot`: - declutter the `Description:` field, moving long description out of the first line - use the reversioned .deb when deploying u-boot to the image - `main_default_build_packages()` now stores reversioned values and complete paths to reversioned .deb's - `list_installed_packages()` now compares custom field `Armbian-Original-Hash: `, and not the `Version:` to make sure debs in the image are the ones we want - `install_artifact_deb_chroot()` is a new wrapper around `install_deb_chroot()` for easy handling of reversioned debs - use it everywhere `install_deb_chroot()` was used in `distro-agnostic.sh` and `distro-specific.sh`
106 lines
4.1 KiB
Bash
106 lines
4.1 KiB
Bash
#!/usr/bin/env bash
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Copyright (c) 2013-2023 Igor Pecovnik, igor@armbian.com
|
|
#
|
|
# This file is a part of the Armbian Build Framework
|
|
# https://github.com/armbian/build/
|
|
|
|
function cli_artifact_pre_run() {
|
|
case "${ARMBIAN_COMMAND}" in
|
|
download-artifact)
|
|
display_alert "download-only mode:" "won't build '${WHAT}'" "info"
|
|
DONT_BUILD_ARTIFACTS="${WHAT}"
|
|
;;
|
|
esac
|
|
|
|
initialize_artifact "${WHAT}"
|
|
# Run the pre run adapter
|
|
artifact_cli_adapter_pre_run
|
|
}
|
|
|
|
function cli_artifact_run() {
|
|
: "${chosen_artifact:?chosen_artifact is not set}"
|
|
: "${chosen_artifact_impl:?chosen_artifact_impl is not set}"
|
|
|
|
if [[ "${CONFIG_DEFS_ONLY}" != "yes" ]]; then
|
|
# Make sure ORAS tooling is installed before starting.
|
|
run_tool_oras
|
|
fi
|
|
|
|
display_alert "artifact" "${chosen_artifact}" "debug"
|
|
display_alert "artifact" "${chosen_artifact} :: ${chosen_artifact_impl}()" "debug"
|
|
declare -g artifact_version_requires_aggregation="no" # marker
|
|
artifact_cli_adapter_config_prep # only if in cli.
|
|
|
|
# if asked by _config_prep to aggregate, and HOSTRELEASE is not set, obtain it.
|
|
if [[ "${artifact_version_requires_aggregation}" == "yes" ]] && [[ -z "${HOSTRELEASE}" ]]; then
|
|
obtain_hostrelease_only # Sets HOSTRELEASE
|
|
fi
|
|
|
|
# When run in GHA, assume we're checking/updating the remote cache only.
|
|
# Local cache is ignored, and if found, it's not unpacked, either from local or remote.
|
|
# If remote cache is found, does nothing.
|
|
declare default_update_remote_only="no"
|
|
if [[ "${CI}" == "true" ]] && [[ "${GITHUB_ACTIONS}" == "true" ]]; then
|
|
display_alert "Running in GitHub Actions, assuming we're updating remote cache only" "GHA remote-only" "info"
|
|
default_update_remote_only="yes"
|
|
fi
|
|
|
|
declare skip_unpack_if_found_in_caches="${skip_unpack_if_found_in_caches:-"${default_update_remote_only}"}"
|
|
declare ignore_local_cache="${ignore_local_cache:-"${default_update_remote_only}"}"
|
|
declare deploy_to_remote="${deploy_to_remote:-"${default_update_remote_only}"}"
|
|
|
|
case "${ARMBIAN_COMMAND}" in
|
|
download-artifact)
|
|
display_alert "Running in download-artifact mode" "download-artifact" "ext"
|
|
skip_unpack_if_found_in_caches="no"
|
|
ignore_local_cache="no"
|
|
deploy_to_remote="no"
|
|
;;
|
|
*)
|
|
# @TODO: rpardini: i'm braindead. I really can't make sense of my own code!
|
|
# If OCI_TARGET_BASE is explicitly set, ignore local, skip if found in remote, and deploy to remote after build.
|
|
if [[ -n "${OCI_TARGET_BASE}" ]]; then
|
|
skip_unpack_if_found_in_caches="yes"
|
|
ignore_local_cache="yes"
|
|
deploy_to_remote="yes"
|
|
|
|
# Pass ARTIFACT_USE_CACHE=yes to actually use the cache versions, but don't deploy to remote.
|
|
# @TODO this is confusing. each op should be individually controlled...
|
|
# what we want is:
|
|
# 1: - check remote, if not found, check local, if not found, build, then deploy to remote
|
|
# - if remote found, do nothing.
|
|
# - if local found, deploy it to remote (for switching targets)
|
|
# 2: - get from remote -> get local -> build, then DON'T deploy to remote
|
|
if [[ "${ARTIFACT_USE_CACHE}" == "yes" ]]; then
|
|
skip_unpack_if_found_in_caches="no"
|
|
ignore_local_cache="no"
|
|
deploy_to_remote="no"
|
|
fi
|
|
fi
|
|
;;
|
|
esac
|
|
|
|
# Force artifacts download we need to populate repository
|
|
if [[ "${FORCE_ARTIFACTS_DOWNLOAD}" == "yes" ]]; then # @TODO should we remove this, Igor?
|
|
skip_unpack_if_found_in_caches="no"
|
|
fi
|
|
|
|
# display a summary of the 3 vars above: skip_unpack_if_found_in_caches, ignore_local_cache, deploy_to_remote
|
|
display_alert "CLI Artifact summary" "skip_unpack_if_found_in_caches=${skip_unpack_if_found_in_caches}, ignore_local_cache=${ignore_local_cache}, deploy_to_remote=${deploy_to_remote}" "info"
|
|
|
|
if [[ "${ARTIFACT_BUILD_INTERACTIVE}" == "yes" ]]; then # Set by `kernel-config`, `kernel-patch`, `uboot-config`, `uboot-patch`, etc.
|
|
display_alert "Running artifact build in interactive mode" "log file will be incomplete" "info"
|
|
do_with_default_build cli_obtain_complete_artifact
|
|
else
|
|
do_with_default_build cli_obtain_complete_artifact < /dev/null
|
|
fi
|
|
}
|
|
|
|
function cli_obtain_complete_artifact() {
|
|
obtain_complete_artifact
|
|
artifact_reversion_for_deployment
|
|
}
|