From b4460a63fa727b8043b5e63870f89a4d679471c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Jirman?= Date: Sat, 1 May 2021 01:28:07 +0200 Subject: [PATCH 089/486] input: goodix: Don't disable regulators during suspend It does no harm to disable them, but on Pinephone we have other peripherals attached to the same power supplies, whose drivers will not reference the regulator, so powering down the regulators from Goodix driver will break those other devices. Until those drivers gain the regulator support, don't disable the regulators in Goodix driver. Signed-off-by: Ondrej Jirman --- drivers/input/touchscreen/goodix.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 82f22b0c2..9ff04fb57 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -1425,8 +1425,6 @@ static int __maybe_unused goodix_suspend(struct device *dev) goodix_free_irq(ts); goodix_irq_direction_output(ts, 0); gpiod_direction_output(ts->gpiod_rst, 0); - regulator_disable(ts->avdd28); - regulator_disable(ts->vddio); return 0; } @@ -1476,18 +1474,6 @@ static int __maybe_unused goodix_resume(struct device *dev) int error; if (ts->poweroff_in_suspend) { - error = regulator_enable(ts->avdd28); - if (error) { - dev_err(dev, "Regulator avdd28 enable failed.\n"); - return error; - } - - error = regulator_enable(ts->vddio); - if (error) { - dev_err(dev, "Regulator vddio enable failed.\n"); - return error; - } - error = goodix_reset(ts); if (error) { dev_err(dev, "Controller reset failed.\n"); -- 2.35.3