Commit Graph

4 Commits

Author SHA1 Message Date
Alban Browaeys
ebb6fb1bec helios64: fix helios64-heartbeat-led.service
Some checks failed
Forked Helper / 📢 Run repository dispatch on fork (push) Waiting to run
Announce PR merge to Discord / announcepush (push) Waiting to run
Scorecards Security Scan / Scorecards analysis (push) Waiting to run
Update Board Lists / Send dispatch (push) Has been cancelled
While syncing with upstream Linux helios64 dts for 6.9 I missed
the diff for the helios64 status led label (upstream was
helios64:green:status instead of Armbian helios64::status) and
thus broke armbian helios64-heartbeat-led.service.

This commit restores the Armbian label helios64::status to let
helios64-heartbeat-led.service starts.

Fixes: cbaf67f00 ("Sync helios64 to its updated 6.9 dts")
Signed-off-by: Alban Browaeys <alban.browaeys@gmail.com>
2025-02-01 23:13:17 +01:00
Alban Browaeys
cce0f3f05d helios64: restore hs400 support after enabling strobe line internal pulldown
Some checks failed
Forked Helper / 📢 Run repository dispatch on fork (push) Waiting to run
Announce PR merge to Discord / announcepush (push) Waiting to run
Scorecards Security Scan / Scorecards analysis (push) Waiting to run
Update Board Lists / Send dispatch (push) Has been cancelled
Since v5.11, Linux upstream commit 8b5c2b45b8f0 disabled the internal pull-down
for the strobe line explicitly instead of leaving it in its default
state (the opposite of Rockchip Kernel which force enable this intrnal
pulldown by default) thus causing I/O errors in HS400 mode for various
eMMC modules (the ones that did not have an external pulldown on the
strobe line likely).
Discussed upstream and the choice has been made to keep this
behavior as it has been there for too long and reverting might break
other boards http://lists.infradead.org/pipermail/linux-rockchip/2024-April/046416.html

HS400 for helios64 was disabled in commit 5f2e23e90
"Disabled hs400 on Helios64 (hopefully only temporarily) (#3126)"
but for 5.10.63 (ie before the above commit disabled internal pulldown).
Back then I had bisected the emmc I/O issue to a double init of the emmc
regulator introduced while adding deferred support to the regulator driver
core, ie commit 06653ebc0ad2 "regulator: core: resolve supply for boot-on/always-on regulators"
in 5.10.60. But due to the new default for the strobe line internal  pulldown
introduced in 5.11, when this double voltage regulator init issue was fixed likely by
8a866d527ac0 "regulator: core: Resolve supply name earlier to prevent double-init"
in Linux 6.1.
2025-01-30 19:06:51 +01:00
Ricardo Pardini
ae6a235582 rockchip64/rockchip-rk3588: rewrite/rebase patches against 6.12 final, no changes 2024-11-20 12:29:44 +01:00
amazingfate
02a4741126 rockchip64-edge: bump to 6.12 2024-11-09 21:43:28 +01:00