mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-08-15 08:57:02 +02:00
09d40e0e08
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a2 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
132 lines
3.0 KiB
C
132 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <arch.h>
|
|
#include <arch_helpers.h>
|
|
#include <lib/el3_runtime/pubsub.h>
|
|
#include <lib/extensions/sve.h>
|
|
|
|
bool sve_supported(void)
|
|
{
|
|
uint64_t features;
|
|
|
|
features = read_id_aa64pfr0_el1() >> ID_AA64PFR0_SVE_SHIFT;
|
|
return (features & ID_AA64PFR0_SVE_MASK) == 1U;
|
|
}
|
|
|
|
static void *disable_sve_hook(const void *arg)
|
|
{
|
|
uint64_t cptr;
|
|
|
|
if (!sve_supported())
|
|
return (void *)-1;
|
|
|
|
/*
|
|
* Disable SVE, SIMD and FP access for the Secure world.
|
|
* As the SIMD/FP registers are part of the SVE Z-registers, any
|
|
* use of SIMD/FP functionality will corrupt the SVE registers.
|
|
* Therefore it is necessary to prevent use of SIMD/FP support
|
|
* in the Secure world as well as SVE functionality.
|
|
*/
|
|
cptr = read_cptr_el3();
|
|
cptr = (cptr | TFP_BIT) & ~(CPTR_EZ_BIT);
|
|
write_cptr_el3(cptr);
|
|
|
|
/*
|
|
* No explicit ISB required here as ERET to switch to Secure
|
|
* world covers it
|
|
*/
|
|
return (void *)0;
|
|
}
|
|
|
|
static void *enable_sve_hook(const void *arg)
|
|
{
|
|
uint64_t cptr;
|
|
|
|
if (!sve_supported())
|
|
return (void *)-1;
|
|
|
|
/*
|
|
* Enable SVE, SIMD and FP access for the Non-secure world.
|
|
*/
|
|
cptr = read_cptr_el3();
|
|
cptr = (cptr | CPTR_EZ_BIT) & ~(TFP_BIT);
|
|
write_cptr_el3(cptr);
|
|
|
|
/*
|
|
* No explicit ISB required here as ERET to switch to Non-secure
|
|
* world covers it
|
|
*/
|
|
return (void *)0;
|
|
}
|
|
|
|
void sve_enable(bool el2_unused)
|
|
{
|
|
uint64_t cptr;
|
|
|
|
if (!sve_supported())
|
|
return;
|
|
|
|
#if CTX_INCLUDE_FPREGS
|
|
/*
|
|
* CTX_INCLUDE_FPREGS is not supported on SVE enabled systems.
|
|
*/
|
|
assert(0);
|
|
#endif
|
|
/*
|
|
* Update CPTR_EL3 to enable access to SVE functionality for the
|
|
* Non-secure world.
|
|
* NOTE - assumed that CPTR_EL3.TFP is set to allow access to
|
|
* the SIMD, floating-point and SVE support.
|
|
*
|
|
* CPTR_EL3.EZ: Set to 1 to enable access to SVE functionality
|
|
* in the Non-secure world.
|
|
*/
|
|
cptr = read_cptr_el3();
|
|
cptr |= CPTR_EZ_BIT;
|
|
write_cptr_el3(cptr);
|
|
|
|
/*
|
|
* Need explicit ISB here to guarantee that update to ZCR_ELx
|
|
* and CPTR_EL2.TZ do not result in trap to EL3.
|
|
*/
|
|
isb();
|
|
|
|
/*
|
|
* Ensure lower ELs have access to full vector length.
|
|
*/
|
|
write_zcr_el3(ZCR_EL3_LEN_MASK);
|
|
|
|
if (el2_unused) {
|
|
/*
|
|
* Update CPTR_EL2 to enable access to SVE functionality
|
|
* for Non-secure world, EL2 and Non-secure EL1 and EL0.
|
|
* NOTE - assumed that CPTR_EL2.TFP is set to allow
|
|
* access to the SIMD, floating-point and SVE support.
|
|
*
|
|
* CPTR_EL2.TZ: Set to 0 to enable access to SVE support
|
|
* for EL2 and Non-secure EL1 and EL0.
|
|
*/
|
|
cptr = read_cptr_el2();
|
|
cptr &= ~(CPTR_EL2_TZ_BIT);
|
|
write_cptr_el2(cptr);
|
|
|
|
/*
|
|
* Ensure lower ELs have access to full vector length.
|
|
*/
|
|
write_zcr_el2(ZCR_EL2_LEN_MASK);
|
|
}
|
|
/*
|
|
* No explicit ISB required here as ERET to switch to
|
|
* Non-secure world covers it.
|
|
*/
|
|
}
|
|
|
|
SUBSCRIBE_TO_EVENT(cm_exited_normal_world, disable_sve_hook);
|
|
SUBSCRIBE_TO_EVENT(cm_entering_normal_world, enable_sve_hook);
|