mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-08-15 17:07:04 +02:00
3ed5606bd1
Currently, when RECLAIM_INIT_CODE is set, the stacks are scaled to ensure that the entirety of the init section can be reclaimed as stack. This causes an issue in lib/psci/aarch64/psci_helpers.S, where the stack size is used for cache operations in psci_do_pwrdown_cache_maintenance(). If the stacks are scaled, then the PSCI code may fail to invalidate some of the stack memory before power down. Resizing stacks is also not good for stability in general, since code that works with a small number of cores may overflow the stack when the number of cores is increased. Change to make every stack be PLATFORM_STACK_SIZE big, and allow the total stack to be smaller than the init section. Any pages of the init section not reclaimed as stack will be set to read-only and execute-never, for security. Change-Id: I10b3884981006431f2fcbec3864c81d4a8c246e8 Signed-off-by: David Horstmann <david.horstmann@arm.com>
44 lines
1.1 KiB
ArmAsm
44 lines
1.1 KiB
ArmAsm
/*
|
|
* Copyright (c) 2017-2020, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
#ifndef ARM_RECLAIM_INIT_LD_S
|
|
#define ARM_RECLAIM_INIT_LD_S
|
|
|
|
SECTIONS
|
|
{
|
|
.init __STACKS_START__ : {
|
|
. = . + PLATFORM_STACK_SIZE;
|
|
. = ALIGN(PAGE_SIZE);
|
|
__INIT_CODE_START__ = .;
|
|
*(*text.init*);
|
|
__INIT_CODE_END__ = .;
|
|
INIT_CODE_END_ALIGNED = ALIGN(PAGE_SIZE);
|
|
} >RAM
|
|
|
|
#ifdef BL31_PROGBITS_LIMIT
|
|
ASSERT(__INIT_CODE_END__ <= BL31_PROGBITS_LIMIT,
|
|
"BL31 init has exceeded progbits limit.")
|
|
#endif
|
|
}
|
|
|
|
#define ABS ABSOLUTE
|
|
|
|
#define STACK_SECTION \
|
|
stacks (NOLOAD) : { \
|
|
__STACKS_START__ = .; \
|
|
*(tzfw_normal_stacks) \
|
|
__STACKS_END__ = .; \
|
|
/* Allow room for the init section where necessary. */ \
|
|
OFFSET = ABS(SIZEOF(.init) - (. - __STACKS_START__)); \
|
|
/* Offset sign */ \
|
|
SIGN = ABS(OFFSET) & (1 << 63); \
|
|
/* Offset mask */ \
|
|
MASK = ABS(SIGN >> 63) - 1; \
|
|
. += ABS(OFFSET) & ABS(MASK); \
|
|
. = ALIGN(PAGE_SIZE); \
|
|
}
|
|
|
|
#endif /* ARM_RECLAIM_INIT_LD_S */
|