mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-08-14 16:37:05 +02:00
09d40e0e08
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a2 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
93 lines
2.5 KiB
C
93 lines
2.5 KiB
C
/*
|
|
* Copyright (c) 2018, Arm Limited. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <assert.h>
|
|
|
|
#include <platform_def.h>
|
|
|
|
#include <common/debug.h>
|
|
#include <tools_share/sptool.h>
|
|
|
|
static unsigned int sp_next;
|
|
|
|
/*******************************************************************************
|
|
* Platform handler get the address of a Secure Partition and its resource
|
|
* description blob. It iterates through all SPs detected by the platform. If
|
|
* there is information for another SP, it returns 0. If there are no more SPs,
|
|
* it returns -1.
|
|
******************************************************************************/
|
|
int plat_spm_sp_get_next_address(void **sp_base, size_t *sp_size,
|
|
void **rd_base, size_t *rd_size)
|
|
{
|
|
assert((sp_base != NULL) && (sp_size != NULL));
|
|
assert((rd_base != NULL) && (rd_base != NULL));
|
|
|
|
const uint64_t *pkg_base = (uint64_t *)PLAT_SP_PACKAGE_BASE;
|
|
|
|
struct sp_pkg_header *pkg_header = (struct sp_pkg_header *)pkg_base;
|
|
|
|
if (sp_next == 0) {
|
|
if (pkg_header->version != 0x1) {
|
|
ERROR("SP package has an unsupported version 0x%llx\n",
|
|
pkg_header->version);
|
|
panic();
|
|
}
|
|
}
|
|
|
|
if (sp_next >= pkg_header->number_of_sp) {
|
|
/* No more partitions in the package */
|
|
return -1;
|
|
}
|
|
|
|
const struct sp_pkg_entry *entry_list =
|
|
(const struct sp_pkg_entry *)((uintptr_t)pkg_base
|
|
+ sizeof(struct sp_pkg_header));
|
|
|
|
const struct sp_pkg_entry *entry = &(entry_list[sp_next]);
|
|
|
|
uint64_t sp_offset = entry->sp_offset;
|
|
uint64_t rd_offset = entry->rd_offset;
|
|
|
|
uintptr_t pkg_sp_base = ((uintptr_t)PLAT_SP_PACKAGE_BASE + sp_offset);
|
|
uintptr_t pkg_rd_base = ((uintptr_t)PLAT_SP_PACKAGE_BASE + rd_offset);
|
|
|
|
uint64_t pkg_sp_size = entry->sp_size;
|
|
uint64_t pkg_rd_size = entry->rd_size;
|
|
|
|
uintptr_t pkg_end = (uintptr_t)PLAT_SP_PACKAGE_BASE
|
|
+ (uintptr_t)PLAT_SP_PACKAGE_SIZE - 1U;
|
|
|
|
/*
|
|
* Check for overflows. The package header isn't trusted, so assert()
|
|
* can't be used here.
|
|
*/
|
|
|
|
uintptr_t pkg_sp_end = pkg_sp_base + pkg_sp_size - 1U;
|
|
uintptr_t pkg_rd_end = pkg_rd_base + pkg_rd_size - 1U;
|
|
|
|
if ((pkg_sp_end > pkg_end) || (pkg_sp_end < pkg_sp_base)) {
|
|
ERROR("Invalid Secure Partition size (0x%llx)\n", pkg_sp_size);
|
|
panic();
|
|
}
|
|
|
|
if ((pkg_rd_end > pkg_end) || (pkg_rd_end < pkg_rd_base)) {
|
|
ERROR("Invalid Resource Description blob size (0x%llx)\n",
|
|
pkg_rd_size);
|
|
panic();
|
|
}
|
|
|
|
/* Return location of the binaries. */
|
|
|
|
*sp_base = (void *)pkg_sp_base;
|
|
*sp_size = pkg_sp_size;
|
|
*rd_base = (void *)pkg_rd_base;
|
|
*rd_size = pkg_rd_size;
|
|
|
|
sp_next++;
|
|
|
|
return 0;
|
|
}
|